You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Eric Newton <er...@gmail.com> on 2015/01/31 00:41:10 UTC
Review Request 30470: Drop the Locator cache every hour
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/
-----------------------------------------------------------
Review request for accumulo.
Repository: accumulo
Description
-------
ACCUMULO-3549
Diffs
-----
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
Diff: https://reviews.apache.org/r/30470/diff/
Testing
-------
Thanks,
Eric Newton
Re: Review Request 30470: Drop the Locator cache every hour
Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 3:16 p.m.)
Review request for accumulo.
Bugs: ACCUMULO-3549
https://issues.apache.org/jira/browse/ACCUMULO-3549
Repository: accumulo
Description
-------
ACCUMULO-3549
Diffs
-----
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
Diff: https://reviews.apache.org/r/30470/diff/
Testing
-------
Thanks,
Eric Newton
Re: Review Request 30470: Drop the Locator cache every hour
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/#review70475
-----------------------------------------------------------
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115693>
What about tables that no longer exist but are in cache?
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115694>
what about order of operations w/ `+` vs `*`?
- kturner
On Jan. 31, 2015, 12:33 a.m., Eric Newton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30470/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:33 a.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-3549
>
>
> Diffs
> -----
>
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
>
> Diff: https://reviews.apache.org/r/30470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Newton
>
>
Re: Review Request 30470: Drop the Locator cache every hour
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/#review70469
-----------------------------------------------------------
Ship it!
Ship It!
- Josh Elser
On Jan. 31, 2015, 12:33 a.m., Eric Newton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30470/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:33 a.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-3549
>
>
> Diffs
> -----
>
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
>
> Diff: https://reviews.apache.org/r/30470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Newton
>
>
Re: Review Request 30470: Drop the Locator cache every hour
Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 12:33 a.m.)
Review request for accumulo.
Repository: accumulo
Description
-------
ACCUMULO-3549
Diffs (updated)
-----
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
Diff: https://reviews.apache.org/r/30470/diff/
Testing
-------
Thanks,
Eric Newton
Re: Review Request 30470: Drop the Locator cache every hour
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/#review70454
-----------------------------------------------------------
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115650>
A real message about what the code was tryign to do would be nice. For example, a table is dropped before we try to clear the cache. A good message could inform the user that it's probably OK to ignore.
"Error clearing tablet locator cache, will continue" or something.
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115648>
Might be worthwhile to add some jitter (maybe +/- a few minutes?). I'm not sure noticable it would be if all tservers dropped their caches at the same time and then started bashing on metadata and root.
- Josh Elser
On Jan. 30, 2015, 11:41 p.m., Eric Newton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30470/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 11:41 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-3549
>
>
> Diffs
> -----
>
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java dfec999
>
> Diff: https://reviews.apache.org/r/30470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Newton
>
>