You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ka...@apache.org on 2020/06/22 20:41:30 UTC

[airflow] branch v1-10-test updated: UX Fix: Prevent undesired text selection with DAG title selection in Chrome (#8912)

This is an automated email from the ASF dual-hosted git repository.

kaxilnaik pushed a commit to branch v1-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v1-10-test by this push:
     new 5e7867f  UX Fix: Prevent undesired text selection with DAG title selection in Chrome (#8912)
5e7867f is described below

commit 5e7867f599c23b487964d2a3016173c3764b41de
Author: Ryan Hamilton <ry...@ryanahamilton.com>
AuthorDate: Tue May 19 19:23:04 2020 -0400

    UX Fix: Prevent undesired text selection with DAG title selection in Chrome (#8912)
    
    Negate user-select in Firefox where behavior is already as desired
    
    (cherry-picked from ce7fdea)
---
 airflow/www_rbac/templates/airflow/dag.html | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/airflow/www_rbac/templates/airflow/dag.html b/airflow/www_rbac/templates/airflow/dag.html
index 7de2cc8..97338b0 100644
--- a/airflow/www_rbac/templates/airflow/dag.html
+++ b/airflow/www_rbac/templates/airflow/dag.html
@@ -26,21 +26,21 @@
 {% endblock %}
 
 {% block content %}
-<div>
+  <div>
     <h3 class="pull-left">
       {% if dag.parent_dag is defined and dag.parent_dag %}
-        <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
+        <span style="color:#aaa;">SUBDAG:</span> <span>{{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <span style="color:#aaa;">DAG:</span> <span>{{ dag.dag_id }}</span>
         <small class="text-muted"> {{ dag.description_unicode[0:150] + '...' if dag.description_unicode and dag.description_unicode|length > 150 else dag.description_unicode|default('', true) }} </small>
       {% endif %}
       {% if root %}
-        <span style='color:#AAA;'>ROOT: </span> <span> {{ root }}</span>
+        <span style="color:#aaa;">ROOT:</span> <span>{{ root }}</span>
       {% endif %}
     </h3>
     <h4 class="pull-right">
-      <a class="label label-default" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
+      <a class="label label-default" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}" style="user-select: none;-moz-user-select: auto;">
         schedule: {{ dag.schedule_interval }}
       </a>
     </h4>
@@ -50,9 +50,9 @@
     {% set base_date_arg = request.args.get('base_date') %}
     {% set num_runs_arg = request.args.get('num_runs') %}
     {% if execution_date is defined %}
-         {% set execution_date_arg = execution_date %}
+      {% set execution_date_arg = execution_date %}
     {% else %}
-        {% set execution_date_arg = request.args.get('execution_date') %}
+      {% set execution_date_arg = request.args.get('execution_date') %}
     {% endif %}
     <ul class="nav nav-pills">
       {% if dag.parent_dag is defined and dag.parent_dag %}