You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Arpit Gupta (JIRA)" <ji...@apache.org> on 2012/10/11 17:43:03 UTC
[jira] [Created] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Arpit Gupta created HADOOP-8917:
-----------------------------------
Summary: add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
Key: HADOOP-8917
URL: https://issues.apache.org/jira/browse/HADOOP-8917
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 1.2.0, 3.0.0
Reporter: Arpit Gupta
Assignee: Arpit Gupta
see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HADOOP-8917:
--------------------------------
Attachment: HADOOP-8917.patch
patch for trunk
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476481#comment-13476481 ]
Arpit Gupta commented on HADOOP-8917:
-------------------------------------
here the test patch output from branch-1
{code}
[exec]
[exec] BUILD SUCCESSFUL
[exec] Total time: 5 minutes 30 seconds
[exec]
[exec]
[exec]
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
[exec]
[exec]
[exec]
[exec]
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================
[exec]
[exec]
{code}
find bugs warnings are not related to this patch and no tests were added as TestSecurityUtil has appropriate coverage
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HADOOP-8917:
--------------------------------
Status: Patch Available (was: Open)
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HADOOP-8917:
--------------------------------
Attachment: HADOOP-8917.branch-1.patch
patch for branch-1. removed un used import as well. Will post the test patch results shortly.
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476448#comment-13476448 ]
Hadoop QA commented on HADOOP-8917:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549200/HADOOP-8917.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//console
This message is automatically generated.
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HADOOP-8917:
--------------------------------
Description:
Webhdfs and fsck when getting the kerberos principal use Locale.US in toLowerCase. We should do the same in replacePattern as this method is used when service prinicpals log in.
see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
was:see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> Webhdfs and fsck when getting the kerberos principal use Locale.US in toLowerCase. We should do the same in replacePattern as this method is used when service prinicpals log in.
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8917) add LOCALE.US to toLowerCase in
SecurityUtil.replacePattern
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476479#comment-13476479 ]
Arpit Gupta commented on HADOOP-8917:
-------------------------------------
no tests added as TestSecurityUtil already has appropriate coverage.
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
> Key: HADOOP-8917
> URL: https://issues.apache.org/jira/browse/HADOOP-8917
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.2.0, 3.0.0
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira