You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/09/25 06:17:44 UTC
[jira] Commented: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634368#action_12634368 ]
Hadoop QA commented on HADOOP-4269:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390884/4269-0.patch
against trunk revision 698721.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/console
This message is automatically generated.
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.