You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2023/02/24 14:04:15 UTC

[tomcat] branch main updated: Document additional RewriteMap types

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 8716b2b1a6 Document additional RewriteMap types
8716b2b1a6 is described below

commit 8716b2b1a673149a5c687240791b3aee5b1a3513
Author: remm <re...@apache.org>
AuthorDate: Fri Feb 24 15:03:49 2023 +0100

    Document additional RewriteMap types
    
    Since I looked at it a few days ago and after reading the docs.
    Overall: probably good enough as it is now.
---
 java/org/apache/catalina/valves/rewrite/RewriteValve.java | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/java/org/apache/catalina/valves/rewrite/RewriteValve.java b/java/org/apache/catalina/valves/rewrite/RewriteValve.java
index a1540f02ba..8bbfdddb82 100644
--- a/java/org/apache/catalina/valves/rewrite/RewriteValve.java
+++ b/java/org/apache/catalina/valves/rewrite/RewriteValve.java
@@ -620,7 +620,16 @@ public class RewriteValve extends ValveBase {
                 } else if (rewriteMapClassName.startsWith("rnd:")) {
                     map = new RandomizedTextRewriteMap(rewriteMapClassName.substring("rnd:".length()), true);
                 } else if (rewriteMapClassName.startsWith("prg:")) {
+                    // FIXME: https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html#prg
+                    // Likely not worth implementing further since this is a simpler CGI
+                    // piping stdin/stdout from an external native process
+                    // Instead assume a class and use the RewriteMap interface
                     rewriteMapClassName = rewriteMapClassName.substring("prg:".length());
+                } else if (rewriteMapClassName.startsWith("dbm:")) {
+                    // FIXME: https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html#dbm
+                    // Probably too specific to HTTP Server to implement
+                } else if (rewriteMapClassName.startsWith("dbd:") || rewriteMapClassName.startsWith("fastdbd:")) {
+                    // FIXME: https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html#dbd
                 }
                 if (map == null) {
                     try {


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org