You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Kirk True (Jira)" <ji...@apache.org> on 2021/06/29 21:58:00 UTC

[jira] [Commented] (KAFKA-12660) Do not update offset commit sensor after append failure

    [ https://issues.apache.org/jira/browse/KAFKA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371669#comment-17371669 ] 

Kirk True commented on KAFKA-12660:
-----------------------------------

[~dengziming] - can I take a look at this? I have some spare cycles to investigate and hopefully fix.

> Do not update offset commit sensor after append failure
> -------------------------------------------------------
>
>                 Key: KAFKA-12660
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12660
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: dengziming
>            Priority: Major
>
> In the append callback after writing an offset to the log in `GroupMetadataManager`, It seems wrong to update the offset commit sensor prior to checking for errors: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala#L394. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)