You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by barthel <gi...@git.apache.org> on 2015/10/02 13:47:01 UTC
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
GitHub user barthel opened a pull request:
https://github.com/apache/maven/pull/68
MNG-3092: Filter Version Range Result
The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range resolving in Maven.
I know about the risk on changing the resolving mechanism in Maven.
I always had the backward compatibility in mind, if I have something changed.
I added some basic tests for the default version range resolver before I've started with the refactoring.
This pull request contains the basic tests and a less invasive solution based on a filter works with resolved version range results.
The actual version range resolving algorithm **wasn't changed** and the internal used default filter implementation don't filter anything.
The goal:
Provide a hook for Maven extensions/plugins to change the list of resolved version range results as required.
These changes are only placed in _maven-aether-provider_.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barthel/maven MNG-3092-filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit fa8daaea046ff3acc7d78ad4bb92d4ada49c3eaa
Author: barthel <ba...@users.noreply.github.com>
Date: 2015-06-23T18:04:41Z
Merge pull request #1 from apache/master
Merge all commits from apache/master into barthel/master.
commit 9010f79b76e1ca97742d1cf095e7aa5fd309d657
Author: barthel <ba...@users.noreply.github.com>
Date: 2015-07-05T20:33:26Z
Merge pull request #2 from apache/master
[MNG-5813] pass debug-opts from mvnDebug to mvn script in the additio…
commit d77335c159d12a2d6fdeaead612017fec681cd1a
Author: tssp <ts...@web.de>
Date: 2015-04-29T08:22:38Z
[MNG-5816] Empy maven.config cause Maven to exit with failure
Avoid adding non empty configuration argument that causes exception.
Signed-off-by: Karl Heinz Marbaise <kh...@apache.org>
commit ffc25a7ccdfc79ecf5cce4ee719505e343017e2c
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-17T18:05:46Z
[maven-release-plugin] prepare release maven-3.3.4
commit cff46e46e474372b90c1e64fa2e23868922feb7f
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-17T18:06:03Z
[maven-release-plugin] prepare for next development iteration
commit 387946320ad98a0336cfe4e2761efc042b67f2bf
Author: Karl Heinz Marbaise <kh...@apache.org>
Date: 2015-07-18T18:59:29Z
Fixed wrong URL to Maven Issue Tracker after
transition to Apache Software Foundation.
commit 65d6452d3a918fbd4455264cc20f72f469290399
Author: Karl Heinz Marbaise <kh...@apache.org>
Date: 2015-07-19T07:53:50Z
Fixed URL's to issue tracking after transition to
Apache Software Foundation.
commit 999edf7d9a3dda202235db4bb8d933c8ce9743e6
Author: Anton Tanasenko <at...@gmail.com>
Date: 2015-07-19T21:01:50Z
MNG-5805: Restore binary compatibility
Signed-off-by: Jason van Zyl <ja...@tesla.io>
commit 6e5e5865c3b532949c88a111c3c7813b402bcea3
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-20T18:05:06Z
[maven-release-plugin] prepare release maven-3.3.5
commit 1a46e29d365fcb815dff2ca3bcadacc46c3ed489
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-20T18:05:24Z
[maven-release-plugin] prepare for next development iteration
commit 6e00e6d415b56a0cdeb742d015c96372ab429336
Author: Stephen Connolly <st...@gmail.com>
Date: 2015-07-22T07:38:05Z
[MNG-5840] The fix for parent version validation caused a regression in the parent version range
- With this change we basically unwind MNG-5840 for the rumoured validation in the workspace resolver
when dealing with a parent version range. Not ideal but only way for now to retain the version range feature
commit 6be2b36bd304d1eb658c717864f60d8831578bf1
Author: Stephen Connolly <st...@gmail.com>
Date: 2015-07-22T08:09:31Z
curses upon you IDE for screwing up the formatting
commit 9590195891448d0f930ee56243b286318ee6dbd6
Author: Stephen Connolly <st...@gmail.com>
Date: 2015-07-22T08:52:01Z
[MNG-5840] The fix for parent version validation caused a regression in the parent version range
- With this change we basically unwind MNG-5840 for the rumoured validation in the workspace resolver
when dealing with a parent version range. Not ideal but only way for now to retain the version range feature
commit 37f9529fae81cb74dc576725eecddf6d29dce993
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-31T02:25:36Z
[maven-release-plugin] prepare release maven-3.3.6
commit 601b3aad9dfe698f73e7f99cd75486f7e31765b7
Author: Jason van Zyl <ja...@tesla.io>
Date: 2015-07-31T02:25:55Z
[maven-release-plugin] prepare for next development iteration
commit d9ce68aa243d432957e8c865c8c28046a0d13e6e
Author: Hervé Boutemy <hb...@apache.org>
Date: 2015-08-02T22:14:51Z
updated wiki content link: docs.codehaus.org has shut down
commit aca247f09ed881dfb796aaffb1ec5115e74c7d54
Author: Hervé Boutemy <hb...@apache.org>
Date: 2015-08-02T22:23:39Z
Plexus is now at github
commit b6d72699c8b0089351f797e217d635424c1ae5a2
Author: barthel <ba...@users.noreply.github.com>
Date: 2015-04-30T12:37:52Z
MNG-3092: Adds version range result filter behaviour
The ```DefaultVersionRangeResolver``` will be extends with a filter for
version range results.
This commit adds a new interfaces ```VersionRangeResultFilter``` and a
non filtering ```DefaultVersionRangeResultFilter```.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-148528528
Is there anything else I can do to help to merge this change or make/explain it better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by barthel <gi...@git.apache.org>.
Github user barthel closed the pull request at:
https://github.com/apache/maven/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-144997575
Only b6d72699c8b0089351f797e217d635424c1ae5a2 contains the enhancements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-148537300
Only b6d7269 is the relevant commit. All other commits are merged from master into my feature branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-148531172
Squash it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-148540247
Create a branch named by the issue on top of master and put a single commit onto it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-3092: Filter Version Range Result
Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/68#issuecomment-148553491
I've open a new PR (#70) based on master and re-created branch MNG-3092. This branch contains the cherry picked b6d7269.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org