You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/17 15:02:19 UTC
[GitHub] [dubbo-go-hessian2] micln opened a new pull request #190: Decode Non-Exist field in Go
micln opened a new pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #183
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] micln commented on pull request #190: Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
micln commented on pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#issuecomment-632080053
this pr has some code for travis debug, I will call for review later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #190: Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#issuecomment-631390055
@wongoo agree with u.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #190: Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#issuecomment-630645871
pls fix the travis failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #190: Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#issuecomment-630693229
there is no log in hessian now， it will return error if something goes wrong. should hessian support log? it may cause lower performance. If yes, I think it's should accept a logger , not calling the `log.Print`.
```go
type loggerFunc func( format string, args... interface)
func emptyLogger ( format string, args... interface) {}
var logger = emptyLogger
func EnableLogger(l loggerFunc){
logger = l
}
func DisableLogger(){
logger = emptyLogger
}
```
@AlexStocks @fangyincheng @hxmhlt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] fangyincheng closed pull request #190: [WIP] Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
fangyincheng closed pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] aliiohs commented on a change in pull request #190: Decode Non-Exist field in Go
Posted by GitBox <gi...@apache.org>.
aliiohs commented on a change in pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#discussion_r427332556
##########
File path: date_test.go
##########
@@ -20,9 +20,7 @@ package hessian
import (
"testing"
"time"
-)
-import (
"github.com/stretchr/testify/assert"
Review comment:
can move to third party package
##########
File path: object.go
##########
@@ -19,12 +19,11 @@ package hessian
import (
"io"
+ "log"
"reflect"
"strings"
"sync"
-)
-import (
perrors "github.com/pkg/errors"
Review comment:
move to third party package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org