You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/02/28 10:32:13 UTC
[PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
potiuk opened a new pull request, #62617:
URL: https://github.com/apache/airflow/pull/62617
Add a pre-push self-review checklist to the "Creating Pull Requests" section of AGENTS.md.
This instructs AI agents to review their own changes against the Gen-AI contribution
guidelines and the code review rules in `.github/instructions/code-review.instructions.md`
before creating a PR.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Opus 4.6
Generated-by: Claude Opus 4.6 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #62617:
URL: https://github.com/apache/airflow/pull/62617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2868993793
##########
AGENTS.md:
##########
@@ -95,6 +99,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
Review Comment:
Got it! It only runs when we ask Agents to review a PR, and it’s not applied to all PR checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2868986209
##########
AGENTS.md:
##########
@@ -95,6 +99,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
Review Comment:
It's just confirmation : This runs only when Agents review a PR and it's not applied to all PR (in checks )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2868965875
##########
AGENTS.md:
##########
@@ -95,6 +99,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
Review Comment:
A type checking stage should be included too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2868987225
##########
AGENTS.md:
##########
@@ -95,6 +99,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
Review Comment:
Run static checks is enough and covers required things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2867461974
##########
AGENTS.md:
##########
@@ -95,6 +95,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --all-files`) and fix any failures.
Review Comment:
We don't need all-files though. Would be very slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2867498895
##########
AGENTS.md:
##########
@@ -95,6 +95,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --all-files`) and fix any failures.
Review Comment:
Indeed - it was copied from the `--all-files` above in AGENTS.md. I changed it to use `--ref-from <target branch>` and did it in the way that if you ask the agent to create PR for 3.1 etc. it should use the right branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org