You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:22:01 UTC

[GitHub] [airflow] tomasfarias commented on issue #11929: add DateTimeBranchOperator

tomasfarias commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-719113348


   Hello 👋 
   
   I've been using Airflow for a while now and would love to get involved with the project and contribute some code. If nobody's working on this I'd like to open a PR. Just wanted to clarify a few questions:
   
   * Should `DateTimeBranchOperator` support comparisons with partial dates? For example: branching based on a comparison between the current date and only a year, instead of a full date. I believe we should, although this may lead to a long argument list as we would need one for each date attribute.
   * Should the operator inherit from `BaseBranchOperator`? Seems to me that would be the best option, but none of the examples mentioned inherit from it (`BranchSQLOperator` and `BranchPythonOperator`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org