You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/04/24 09:46:01 UTC
[GitHub] [calcite] danny0405 opened a new pull request #1943: [CALCITE-3955] Remove the first operand of RexCall from SqlWindowTabl…
danny0405 opened a new pull request #1943:
URL: https://github.com/apache/calcite/pull/1943
…eFunction
In CALCITE-3382, we introduced TUMBLE window function to replace the
deprecated group tumble window.
But for query
```sql
select *
from table(tumble(table Shipments, descriptor(rowtime), INTERVAL '1'
MINUTE))
```
the output plan is
```xml
LogicalProject(ORDERID=[$0], ROWTIME=[$1], window_start=[$2],
window_end=[$3])
LogicalTableFunctionScan(invocation=[TUMBLE($1, DESCRIPTOR($1),
60000:INTERVAL MINUTE)], rowType=[RecordType(INTEGER ORDERID,
TIMESTAMP(0) ROWTIME, TIMESTAMP(0) window_start, TIMESTAMP(0)
window_end)])
LogicalProject(ORDERID=[$0], ROWTIME=[$1])
LogicalTableScan(table=[[CATALOG, SALES, SHIPMENTS]])
```
The first operand of TUMBLE rex call is always the last
input field, but actually it represents the source table
which is the input rel node.
Removes the first operand from the RexCall because
it is useless and confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] amaliujia commented on pull request #1943: [CALCITE-3955] Remove the first operand of RexCall from SqlWindowTabl…
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1943:
URL: https://github.com/apache/calcite/pull/1943#issuecomment-619180717
LGTM
The change in this PR makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org