You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2023/02/20 16:54:27 UTC
[camel] branch main updated: (chores) camel-opentelemetry: use logs instead of printing to stdout
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 0be67c55ad3 (chores) camel-opentelemetry: use logs instead of printing to stdout
0be67c55ad3 is described below
commit 0be67c55ad31922c520d8ff6724683419204b4ce
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Mon Feb 20 16:22:15 2023 +0100
(chores) camel-opentelemetry: use logs instead of printing to stdout
---
.../camel/opentelemetry/CamelOpenTelemetryTestSupport.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/components/camel-opentelemetry/src/test/java/org/apache/camel/opentelemetry/CamelOpenTelemetryTestSupport.java b/components/camel-opentelemetry/src/test/java/org/apache/camel/opentelemetry/CamelOpenTelemetryTestSupport.java
index d7438977838..d0139a7f6a0 100644
--- a/components/camel-opentelemetry/src/test/java/org/apache/camel/opentelemetry/CamelOpenTelemetryTestSupport.java
+++ b/components/camel-opentelemetry/src/test/java/org/apache/camel/opentelemetry/CamelOpenTelemetryTestSupport.java
@@ -46,13 +46,14 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
class CamelOpenTelemetryTestSupport extends CamelTestSupport {
-
static final AttributeKey<String> CAMEL_URI_KEY = AttributeKey.stringKey("camel-uri");
static final AttributeKey<String> COMPONENT_KEY = AttributeKey.stringKey("component");
static final AttributeKey<String> PRE_KEY = AttributeKey.stringKey("pre");
static final AttributeKey<String> POST_KEY = AttributeKey.stringKey("post");
static final AttributeKey<String> MESSAGE_KEY = AttributeKey.stringKey("message");
+ private static final Logger LOG = LoggerFactory.getLogger(CamelOpenTelemetryTestSupport.class);
+
private InMemorySpanExporter inMemorySpanExporter = InMemorySpanExporter.create();
private SpanTestData[] expected;
private Tracer tracer;
@@ -95,10 +96,10 @@ class CamelOpenTelemetryTestSupport extends CamelTestSupport {
protected List<SpanData> verify(SpanTestData[] expected, boolean async) {
List<SpanData> spans = inMemorySpanExporter.getFinishedSpanItems();
spans.forEach(mockSpan -> {
- System.out.println("Span: " + mockSpan);
- System.out.println("\tComponent: " + mockSpan.getAttributes().get(COMPONENT_KEY));
- System.out.println("\tTags: " + mockSpan.getAttributes());
- System.out.println("\tLogs: ");
+ LOG.info("Span: {}", mockSpan);
+ LOG.info("Component: {}", mockSpan.getAttributes().get(COMPONENT_KEY));
+ LOG.info("Tags: {}", mockSpan.getAttributes());
+ LOG.info("Logs: ");
});
assertEquals(expected.length, spans.size(), "Incorrect number of spans");