You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org> on 2011/11/24 15:24:39 UTC

[jira] [Commented] (WICKET-4250) Checks in IRequestMapper.mapHandler should be on page instance, if available

    [ https://issues.apache.org/jira/browse/WICKET-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156722#comment-13156722 ] 

Martin Grigorov commented on WICKET-4250:
-----------------------------------------

I guess a test case wont be very simple to be created...
At least the patch is simple.
                
> Checks in IRequestMapper.mapHandler should be on page instance, if available
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-4250
>                 URL: https://issues.apache.org/jira/browse/WICKET-4250
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.3
>            Reporter: Emond Papegaaij
>         Attachments: 0001-WICKET-4250.patch
>
>
> AbstractBookmarkableMapper and MountedMapper only check if a the page class match that of the mount, even when a page instance is available. This makes it difficult to use the classes as superclass in a single-page application, where the same page can be mounted at different urls. The attached patch allows checks on the page instance to be implemented in subclasses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira