[GitHub] [cassandra] dcapwell commented on a change in pull request #747: CircleCI should run cqlshlib tests

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #747:
URL: https://github.com/apache/cassandra/pull/747#discussion_r517552633



##########
File path: .circleci/config-2_1.yml
##########
@@ -866,6 +898,23 @@ commands:
         path: /tmp/cassandra/build/test/logs
         destination: logs
 
+  run_cqlshlib_tests:
+    parameters:
+      no_output_timeout:
+        type: string
+        default: 15m
+    steps:
+    - run:
+        name: Run cqlshlib Unit Tests
+        command: |
+          export PATH=$JAVA_HOME/bin:$PATH
+          time mv ~/cassandra /tmp
+          cd /tmp/cassandra/pylib
+          ./cassandra-cqlsh-tests.sh ..
+        no_output_timeout: <<parameters.no_output_timeout>>
+    - store_test_results:

Review comment:
       can we also store the logs?  here is what we do for unit test
   
   ```
       - store_test_results:
           path: /tmp/cassandra/build/test/output/
       - store_artifacts:
           path: /tmp/cassandra/build/test/output
           destination: junitxml
       - store_artifacts:
           path: /tmp/cassandra/build/test/logs
           destination: logs
   ```
   
   If a test fails, we need a way to to look at the results to debug




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org