You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by an...@apache.org on 2024/01/05 19:51:02 UTC

(beam) branch master updated: Remove TODO in the notebook (#29935)

This is an automated email from the ASF dual-hosted git repository.

anandinguva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new b9ae59a9978 Remove TODO in the notebook (#29935)
b9ae59a9978 is described below

commit b9ae59a99789b76948b771a9c9240f5de9a1c9de
Author: Anand Inguva <34...@users.noreply.github.com>
AuthorDate: Fri Jan 5 14:50:55 2024 -0500

    Remove TODO in the notebook (#29935)
    
    * Update vertex_ai_text_embeddings.ipynb
    
    * Update vertex_ai_text_embeddings.ipynb
    
    * Update vertex_ai_text_embeddings.ipynb
    
    * Apply suggestions from code review
    
    Co-authored-by: Rebecca Szper <98...@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Rebecca Szper <98...@users.noreply.github.com>
---
 .../beam-ml/data_preprocessing/vertex_ai_text_embeddings.ipynb         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/examples/notebooks/beam-ml/data_preprocessing/vertex_ai_text_embeddings.ipynb b/examples/notebooks/beam-ml/data_preprocessing/vertex_ai_text_embeddings.ipynb
index 352e1124d82..1207793f5a1 100644
--- a/examples/notebooks/beam-ml/data_preprocessing/vertex_ai_text_embeddings.ipynb
+++ b/examples/notebooks/beam-ml/data_preprocessing/vertex_ai_text_embeddings.ipynb
@@ -107,8 +107,7 @@
         "from google.colab import auth\n",
         "auth.authenticate_user()\n",
         "\n",
-        "# TODO: Remove the project name before merging.\n",
-        "project = 'google.com:clouddfe' # Replace with a valid project id."
+        "project = '<PROJECT_ID>' # Replace <PROJECT_ID> with a valid Google Cloud project ID."
       ],
       "metadata": {
         "id": "nYyyGYt3licq"