Re: [PR] Managed BigQueryIO [beam]

["chamikaramj (via GitHub)" <gi...@apache.org>]

chamikaramj commented on code in PR #31486:
URL: https://github.com/apache/beam/pull/31486#discussion_r1830100269


##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java:
##########
@@ -134,53 +141,62 @@ private Map<String, Object> resolveUnderlyingConfig() {
 
       return YamlUtils.yamlStringToMap(yamlTransformConfig);
     }
+
+    @VisibleForTesting
+    ManagedConfig resolveUnderlyingTransform(PCollectionRowTuple input) {

Review Comment:
   I suggest pushing this BQ logic to a ```BQWriteSchemaTransformProvider``` instead of keeping at the ```ManagedSchemaTransformProvider```.
   
   ```ManagedSchemaTransformProvider``` will replace ```BigQueryFileLoadsWriteSchemaTransformProvider``` and ```BigQueryStorageWriteApiSchemaTransform``` and will expand to the correct implementation within the "expand" method.
   
   ```ManagedSchemaTransformProvider``` will use the ```BigQueryWriteConfiguration``` (which is already shared between the above two implementations).
   
   This way, the Managed layer can be completely abstracted out from the implementation details of the BigQuery write transform.
   
   WDYT ?
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org