You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Nicolás Donatucci <nd...@medallia.com> on 2017/09/11 14:59:06 UTC
Review Request 62220: Add ca-certificates-java to ubuntu-trusty
Dockerfile
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62220/
-----------------------------------------------------------
Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
Repository: aurora-packaging
Description
-------
Add ca-certificates-java to ubuntu-trusty Dockerfile
When building Aurora 0.17 and 0.18 debs I had an error because there were no ca-certificates. Adding the ca-certificates-java to the apt-get step in the Dockerfile fixes this for both 0.17 and 0.18
Diffs
-----
builder/deb/ubuntu-trusty/Dockerfile 771254918bea6a56ba64998cb343e68fb5cbece1
Diff: https://reviews.apache.org/r/62220/diff/1/
Testing
-------
Thanks,
Nicolás Donatucci
Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty
Dockerfile
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62220/#review185125
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Sept. 11, 2017, 7:59 a.m., Nicolás Donatucci wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62220/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2017, 7:59 a.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add ca-certificates-java to ubuntu-trusty Dockerfile
>
> When building Aurora 0.17 and 0.18 debs I had an error because there were no ca-certificates. Adding the ca-certificates-java to the apt-get step in the Dockerfile fixes this for both 0.17 and 0.18
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/Dockerfile 771254918bea6a56ba64998cb343e68fb5cbece1
>
>
> Diff: https://reviews.apache.org/r/62220/diff/1/
>
>
> Testing
> -------
>
> Built Aurora 0.18 and 0.17
>
>
> Thanks,
>
> Nicolás Donatucci
>
>
Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty
Dockerfile
Posted by Renan DelValle <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62220/#review185124
-----------------------------------------------------------
Ship it!
This seems to be a solution to the intermitent errors that show up once in a blue moon on the nightly builds (e.g. https://lists.apache.org/thread.html/ea328642b58ad0f72576d8697cf7dc4c0052a5190ba53c2f4c95013b@%3Cdev.aurora.apache.org%3E )
- Renan DelValle
On Sept. 11, 2017, 7:59 a.m., Nicolás Donatucci wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62220/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2017, 7:59 a.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add ca-certificates-java to ubuntu-trusty Dockerfile
>
> When building Aurora 0.17 and 0.18 debs I had an error because there were no ca-certificates. Adding the ca-certificates-java to the apt-get step in the Dockerfile fixes this for both 0.17 and 0.18
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/Dockerfile 771254918bea6a56ba64998cb343e68fb5cbece1
>
>
> Diff: https://reviews.apache.org/r/62220/diff/1/
>
>
> Testing
> -------
>
> Built Aurora 0.18 and 0.17
>
>
> Thanks,
>
> Nicolás Donatucci
>
>
Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty
Dockerfile
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62220/#review185739
-----------------------------------------------------------
Ship it!
Thanks!
- Stephan Erb
On Sept. 11, 2017, 4:59 p.m., Nicolás Donatucci wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62220/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2017, 4:59 p.m.)
>
>
> Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add ca-certificates-java to ubuntu-trusty Dockerfile
>
> When building Aurora 0.17 and 0.18 debs I had an error because there were no ca-certificates. Adding the ca-certificates-java to the apt-get step in the Dockerfile fixes this for both 0.17 and 0.18
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/Dockerfile 771254918bea6a56ba64998cb343e68fb5cbece1
>
>
> Diff: https://reviews.apache.org/r/62220/diff/1/
>
>
> Testing
> -------
>
> Built Aurora 0.18 and 0.17
>
>
> Thanks,
>
> Nicolás Donatucci
>
>