You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "EiyuuZack (via GitHub)" <gi...@apache.org> on 2023/11/27 12:56:10 UTC
Re: [PR] feat!: API 34 Support [cordova-android]
EiyuuZack commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406120145
##########
framework/build.gradle:
##########
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
- sourceCompatibility JavaVersion.VERSION_1_8
- targetCompatibility JavaVersion.VERSION_1_8
+ sourceCompatibility JavaVersion.VERSION_17
Review Comment:
Hey guys, quick question I am struggling to find answers for:
Considering the `minSdk` currently in effect (API Level 24), how can you be sure there won't be any issues targeting Java 17?
As of today, generating a pure Android project using AS Hedgehog RC and AGP 8.2.0-rc03 still results in a Gradle file containing:
```
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = '1.8'
}
```
It seems Google is not ready to pull the trigger on Java 17 yet, so I am wondering if Cordova should?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org