[GitHub] [solr] atris commented on a change in pull request #193: SOLR-15474: Support Pluggable Circuit Breakers

[GitBox <gi...@apache.org>]

atris commented on a change in pull request #193:
URL: https://github.com/apache/solr/pull/193#discussion_r663656802



##########
File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##########
@@ -135,15 +125,61 @@ public static String toErrorMessage(List<CircuitBreaker> circuitBreakerList) {
    *
    * Any default circuit breakers should be registered here.
    */
+  @Deprecated
   public static CircuitBreakerManager build(PluginInfo pluginInfo) {
+    return build(pluginInfo, null);
+  }
+
+  /**
+   * TODO
+   */
+  public static CircuitBreakerManager build(PluginInfo pluginInfo, SolrResourceLoader solrResourceLoader) {
     boolean enabled = pluginInfo == null ? false : Boolean.parseBoolean(pluginInfo.attributes.getOrDefault("enabled", "false"));
     CircuitBreakerManager circuitBreakerManager = new CircuitBreakerManager(enabled);
 
-    circuitBreakerManager.init(pluginInfo);
+    circuitBreakerManager.init(pluginInfo, solrResourceLoader);
 
     return circuitBreakerManager;
   }
 
+  /**
+   * Initialize with circuit breakers defined in the configuration
+   */
+  public void init(PluginInfo pluginInfo, SolrResourceLoader solrResourceLoader) {

Review comment:
       Yes, I did. The main challenge was that both (ResourceLoader and PluginInfo list) need to be present when CircuitBreakerManager can be initialised. If ResourceLoaderAware and PluginInfoInitialized are used, then CircuitBreakerManager will have to maintain state for both until they are both present, and then initialise itself. This seems a bit of an overkill?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org