You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/22 13:16:16 UTC

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #5555: [Colocate plan][Step2] Colocate aggregation covers more situations

EmmyMiao87 opened a new pull request #5555:
URL: https://github.com/apache/incubator-doris/pull/5555


   ## Proposed changes
   
   [Colocate plan][Step2] Colocate aggregation covers more situations
   
       The old colocate aggregation can only cover the case where the child is scan.
       In fact, as long as the child's data distribution meets the requirements,
         no matter what the plan node on the child node is, a colocate aggregation can be performed.
   
       This PR also fixes the correct data partition attribute of fragment.
       The data partition of fragment which contains scan node is Hash Partition rather than Random.
       This modification is mainly to determine the possibility of colocate
         through the correct distribution of child fragments.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have created an issue on (Fix #5184) and described the bug/feature there in detail
   - [x] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   unit test is coming.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #5555: [Colocate plan][Step2] Colocate aggregation covers more situations

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5555:
URL: https://github.com/apache/incubator-doris/pull/5555


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #5555: [Colocate plan][Step2] Colocate aggregation covers more situations

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-doris/pull/5555#discussion_r618484554



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -974,6 +984,64 @@ private PlanFragment createAggregationFragment(
         }
     }
 
+    /**
+     * Colocate Agg can be performed when the following 2 conditions are met at the same time.
+     * 1. Session variables disable_colocate_plan = true
+     * 2. The input data partition of child fragment < agg node partition exprs
+     */
+    private boolean canColocateAgg(AggregateInfo aggregateInfo, List<DataPartition> childFragmentDataPartition) {
+        // Condition1
+        if (ConnectContext.get().getSessionVariable().isDisableColocatePlan()) {
+            LOG.info("Agg node is not colocate in:" + ConnectContext.get().getQueryDetail().getQueryId()

Review comment:
       debug level

##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -475,7 +480,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
 
     /**
      * Colocate Join can be performed when the following 4 conditions are met at the same time.
+<<<<<<< HEAD
      * 1. Session variables disable_colocate_plan = false
+=======
+     * 1. Session variables disable_colocate_plan = true
+>>>>>>> 26f4e1fa8 ([Colocate plan][Step1] Colocate join covers more situations)

Review comment:
       Conflict?

##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -974,6 +984,64 @@ private PlanFragment createAggregationFragment(
         }
     }
 
+    /**
+     * Colocate Agg can be performed when the following 2 conditions are met at the same time.
+     * 1. Session variables disable_colocate_plan = true

Review comment:
       disable_colocate_plan=false?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org