You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/27 08:02:36 UTC
[GitHub] [pulsar] kimula opened a new pull request, #15344: [pulsar-client-cpp] Upgrade protobuf
kimula opened a new pull request, #15344:
URL: https://github.com/apache/pulsar/pull/15344
### Motivation
protobuf 3.3.0 is vulnerable.
https://snyk.io/vuln/pip:protobuf
### Modifications
upgrade the version of protobuf set to 3.3.0 in pulsar-client-cpp to 3.20.0.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kimula commented on pull request #15344: [pulsar-client-cpp] Upgrade protobuf
Posted by GitBox <gi...@apache.org>.
kimula commented on PR #15344:
URL: https://github.com/apache/pulsar/pull/15344#issuecomment-1124478429
@BewareMyPower I undid an unneccessary change of `cmake`. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #15344: [pulsar-client-cpp] Upgrade protobuf
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #15344:
URL: https://github.com/apache/pulsar/pull/15344#issuecomment-1110898687
```
/home/runner/work/pulsar/pulsar/pulsar-client-cpp
bash: line 1: /opt/cmake/cmake-3.20.0.0-Linux-x86_64/bin/cmake: No such file or directory
```
Could you verify the Dockerfile locally before pushing the patch? It looks like we shouldn't modify the path to `cmake`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #15344: [pulsar-client-cpp] Upgrade protobuf
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #15344:
URL: https://github.com/apache/pulsar/pull/15344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org