[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #326: [YUNIKORN-932] Added some extra log message

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #326:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/326#discussion_r748029173



##########
File path: pkg/shim/scheduler.go
##########
@@ -256,7 +265,9 @@ func (ss *KubernetesShim) canHandle(se events.SchedulerEvent) bool {
 func (ss *KubernetesShim) schedule() {
 	apps := ss.context.SelectApplications(nil)
 	for _, app := range apps {
-		app.Schedule()
+		if app.Schedule() {
+			ss.outstandingAppsFound = true
+		}

Review comment:
       We cannot simplify it because if in a cycle we found some outstanding apps, but in the next one not, we don't want to owerride it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org