You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "James Netherton (Jira)" <ji...@apache.org> on 2021/09/28 13:10:00 UTC

[jira] [Commented] (CAMEL-16837) Camel-aws2-ddbstream: Batch consumer is not implemented although documentation says that it should be

    [ https://issues.apache.org/jira/browse/CAMEL-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421373#comment-17421373 ] 

James Netherton commented on CAMEL-16837:
-----------------------------------------

For reference, the notes in the component docs for this feature was removed in the commit linked below. It'll need restoring when the feature is fully implemented.

https://github.com/apache/camel/commit/2fa2758fd921550157616cc821897498a5d530e2


> Camel-aws2-ddbstream: Batch consumer is not implemented although documentation says that it should be
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-16837
>                 URL: https://issues.apache.org/jira/browse/CAMEL-16837
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-aws2
>    Affects Versions: 3.11.0
>            Reporter: Jiri Ondrusek
>            Assignee: Andrea Cosentino
>            Priority: Major
>
> I'm adding the test coverage for aws2-ddbstream component in camel-quarkus ([issue|https://github.com/apache/camel-quarkus/issues/2776]).
> According to the [doc|https://camel.apache.org/components/3.7.x/aws2-ddbstream-component.html#_batch_consumer], batch consumer should be implemented. I see in code that consumer extends `ScheduledBatchPollingConsumer` ([git|https://github.com/apache/camel/blob/main/components/camel-aws/camel-aws2-ddb/src/main/java/org/apache/camel/component/aws2/ddbstream/Ddb2StreamConsumer.java#L38]). Aws2-ddbstream compoinent does not allow to specifies e.g. `maxMessagesPerPoll` or doesn't return any header which should be returned according to [doc|https://camel.apache.org/manual/latest/batch-consumer.html].
> It seems that aws2-ddbstream component implements `BatchConsumer.processBatch`, but does not use (even if it implements all of the required methods) the rest of the `batchConsumer` logic.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)