You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2025/06/06 22:40:10 UTC
[PR] Fix serialization of DeadlineAlert and add unit tests to prevent regr… [airflow]
ferruzzi opened a new pull request, #51494:
URL: https://github.com/apache/airflow/pull/51494
Found a bug in the serialization implementation once the DeadlineReferences were added and I was able to do some better integration testing. This should be way more robust. I also added a note in the code that this current implementation does not support using a lambda as a callback because of how I'm doing the serialization. I'm not sure how important we feel that is, I think it can wait.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serialization of DeadlineAlert and add unit tests to prevent regr… [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #51494:
URL: https://github.com/apache/airflow/pull/51494#discussion_r2132997060
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -136,6 +162,30 @@ def _evaluate_with(self, **kwargs: Any) -> datetime:
"""Must be implemented by subclasses to perform the actual evaluation."""
raise NotImplementedError
+ @classmethod
+ def deserialize_reference(cls, reference_data: dict):
Review Comment:
`reference_data` is not used by the base/default implementation but is used for References which accept a parameter, like FixedDatetimeReference (below). It is in this signature to maintain signature consistency.
##########
airflow-core/src/airflow/models/dag.py:
##########
@@ -1917,7 +1918,7 @@ class DagModel(Base):
# Asset expression based on asset triggers
asset_expression = Column(sqlalchemy_jsonfield.JSONField(json=json), nullable=True)
# DAG deadline information
- deadline = Column(sqlalchemy_jsonfield.JSONField(json=json), nullable=True)
+ _deadline = Column("deadline", sqlalchemy_jsonfield.JSONField(json=json), nullable=True)
Review Comment:
This change allows us to change the python name of the column without changing the actual SQL name, so no migration is needed. I did it this way so the property (below) can use the existing name and allow for proper serialization/deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serialization of DeadlineAlert and add unit tests to prevent regr… [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #51494:
URL: https://github.com/apache/airflow/pull/51494#issuecomment-2964531090
Hey guys, my first PR :rofl:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serialization of DeadlineAlert and add unit tests to prevent regr… [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #51494:
URL: https://github.com/apache/airflow/pull/51494#issuecomment-2964530523
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serialization of DeadlineAlert and add unit tests to prevent regr… [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi merged PR #51494:
URL: https://github.com/apache/airflow/pull/51494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org