You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/03 08:57:30 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request #2868: [INLONG-2867][Manager] Support report the task result and get tasks for the agent
healchow opened a new pull request #2868:
URL: https://github.com/apache/incubator-inlong/pull/2868
### Title Name: [INLONG-2867][Manager] Support report the task result and get tasks for the agent
Fixes #2867
### Motivation
Support report the task result and get tasks for the agent.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [X] Make sure that the change passes the CI checks.
This change is a trivial rework/code cleanup without any test coverage.
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2868: [INLONG-2867][Manager] Support report the task result and get tasks for the agent
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2868:
URL: https://github.com/apache/incubator-inlong/pull/2868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2868: [INLONG-2867][Manager] Support report the task result and get tasks for the agent
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2868:
URL: https://github.com/apache/incubator-inlong/pull/2868#discussion_r818619869
##########
File path: inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/conf/TriggerProfile.java
##########
@@ -20,12 +20,22 @@
import org.apache.inlong.agent.constant.JobConstants;
import org.apache.inlong.agent.pojo.JobProfileDto;
import org.apache.inlong.common.pojo.agent.DataConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
/**
* profile used in trigger. Trigger profile is a special job profile
*/
public class TriggerProfile extends JobProfile {
+ private static final Logger LOGGER = LoggerFactory.getLogger(TriggerProfile.class);
+
+ private final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
Review comment:
OK, I replaced `SimpleDateFormat ` by `DateTimeFormatter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] aloyszhang commented on a change in pull request #2868: [INLONG-2867][Manager] Support report the task result and get tasks for the agent
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on a change in pull request #2868:
URL: https://github.com/apache/incubator-inlong/pull/2868#discussion_r818599786
##########
File path: inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/conf/TriggerProfile.java
##########
@@ -20,12 +20,22 @@
import org.apache.inlong.agent.constant.JobConstants;
import org.apache.inlong.agent.pojo.JobProfileDto;
import org.apache.inlong.common.pojo.agent.DataConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
/**
* profile used in trigger. Trigger profile is a special job profile
*/
public class TriggerProfile extends JobProfile {
+ private static final Logger LOGGER = LoggerFactory.getLogger(TriggerProfile.class);
+
+ private final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
Review comment:
SimpleDateFormat is not thread-safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org