You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/03/04 00:34:56 UTC
[jira] Created: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
minor : avoid building error string in verifyReplication()
----------------------------------------------------------
Key: HADOOP-5383
URL: https://issues.apache.org/jira/browse/HADOOP-5383
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Raghu Angadi
Assignee: Raghu Angadi
Priority: Minor
On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678792#action_12678792 ]
Hadoop QA commented on HADOOP-5383:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401342/HADOOP-5383.patch
against trunk revision 749919.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/console
This message is automatically generated.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5383:
-------------------------------------------
Description:
On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
This jira fixes it.
was:
On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
This jira fixes it.
Hadoop Flags: [Reviewed]
+1 patch looks good.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5383:
---------------------------------
Status: Patch Available (was: Open)
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678842#action_12678842 ]
Giridharan Kesavan commented on HADOOP-5383:
--------------------------------------------
could you resubmit the patch to hudson ?
The previous failure is for a different environment issue.
tnx!
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678554#action_12678554 ]
Raghu Angadi commented on HADOOP-5383:
--------------------------------------
Thanks Nicholas. I will commit it once Hudson blesses it.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678556#action_12678556 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5383:
------------------------------------------------
Not at all.
BTW, the description was changed automatically: I guess it was changed when I clicked 'edit'. The leading empty was removed automatically.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681800#action_12681800 ]
Hudson commented on HADOOP-5383:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5383:
---------------------------------
Attachment: HADOOP-5383.patch
A trivial patch.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5383) minor : avoid building error string
in verifyReplication()
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5383:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
(There is no need for another Hudson run. This is a trivial fix).
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to check if it falls within the configured limits. Currently its implementation always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.