You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2018/10/08 15:45:00 UTC

[jira] [Commented] (BEAM-5678) Jeckyll redirect_from incompatible with HTMLProofer url validation

    [ https://issues.apache.org/jira/browse/BEAM-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642031#comment-16642031 ] 

Scott Wegner commented on BEAM-5678:
------------------------------------

[~alanmyrvold], [~udim] and I spent some time investigating this and didn't find easy work-arounds.

The [jekyll-redirect-from|https://github.com/jekyll/jekyll-redirect-from] plugin responsible for creating the redirect pages uses absolute paths for the "redirect to" URL, which is what causes issues. The plugin allows providing a custom page template, but only provides the absolute redirect-to URL as a variable.

> Jeckyll redirect_from incompatible with HTMLProofer url validation
> ------------------------------------------------------------------
>
>                 Key: BEAM-5678
>                 URL: https://issues.apache.org/jira/browse/BEAM-5678
>             Project: Beam
>          Issue Type: Sub-task
>          Components: website
>            Reporter: Scott Wegner
>            Priority: Minor
>
> Renaming a URL and using the Jekyll {{redirect_from}} feature breaks pre-commit validation.
> We hit this on [PR580|https://github.com/apache/beam-site/pull/580#issuecomment-427516952]:
> bq. The scenario for using a redirect is if you're moving {{pageA.md}} to {{pageB.md}}; you would rename the file to {{pageB.md}} and add {{redirect_from: pageA}}. This will cause jekyll to generate a {{pageA.html}} with a redirect to {{https://beam.apache.org/pageB.html}}. But {{pageB.html}} doesn't exist on the livesite yet, so it will always fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)