You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Mladen Turk (JIRA)" <ji...@apache.org> on 2010/05/23 18:34:23 UTC

[jira] Created: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
-------------------------------------------------------------------------

                 Key: TS-367
                 URL: https://issues.apache.org/jira/browse/TS-367
             Project: Traffic Server
          Issue Type: Task
          Components: Cleanup
            Reporter: Mladen Turk
            Assignee: Mladen Turk
            Priority: Trivial
             Fix For: 2.1.0


At least since version 2 configure will fail unless user
has openssl-dev installed which makes openssl mandatory
and which is fine.

Any objection to remove the #ifdef HAVE_LIBSSL preproc
tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mladen Turk updated TS-367:
---------------------------

    Attachment: axe-opessl-test.patch

Patch to cleanup the HAVE_LIBSSL preproc tests

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Mladen Turk
>            Priority: Trivial
>             Fix For: 2.1.0
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886875#action_12886875 ] 

Leif Hedstrom commented on TS-367:
----------------------------------

Meh, lets just require OpenSSL, it's easier. +1 on just applying this patch, and remove the check entirely.

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Mladen Turk
>            Priority: Trivial
>             Fix For: 2.1.2
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom reassigned TS-367:
--------------------------------

    Assignee: Leif Hedstrom  (was: Mladen Turk)

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Leif Hedstrom
>            Priority: Trivial
>             Fix For: 2.1.3
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mladen Turk updated TS-367:
---------------------------

    Fix Version/s: 2.1.2
                       (was: 2.1.1)

Target for 2.1.2 and make the OpenSSL optional.
This requires to use the our own md5 in that case (port from APR)

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Mladen Turk
>            Priority: Trivial
>             Fix For: 2.1.2
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872840#action_12872840 ] 

Leif Hedstrom commented on TS-367:
----------------------------------

Would it make sense to make SSL truly "optional" ? If so, maybe move this out for a "future" version, instead of nuking it? I'm OK either way, but my "preference" would be to make SSL optional.

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Mladen Turk
>            Priority: Trivial
>             Fix For: 2.1.1
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TS-367) Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom resolved TS-367.
------------------------------

    Resolution: Fixed

I committed this, thanks for the patch Mladen!

> Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement
> -------------------------------------------------------------------------
>
>                 Key: TS-367
>                 URL: https://issues.apache.org/jira/browse/TS-367
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Leif Hedstrom
>            Priority: Trivial
>             Fix For: 2.1.3
>
>         Attachments: axe-opessl-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At least since version 2 configure will fail unless user
> has openssl-dev installed which makes openssl mandatory
> and which is fine.
> Any objection to remove the #ifdef HAVE_LIBSSL preproc
> tests since they are always true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.