You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by KunShuai Zhu <jo...@gmail.com> on 2021/07/27 16:32:09 UTC
Why the parent module of shenyu-integrated-test is springboot?
Hi community,
I found that springboot is written in the <parent> tag in the pom.xml
of the shenyu-integrated-test module. Shouldn't you fill in `shenyu`
here? And this led to the lack of checkstyle in
shenyu-integrated-test, which resulted in a lot of code style errors.
If this is wrong, I can help to correct this, and then correct the
code style error in shenyu-integrated-test. Or it should be springboot
here, I can add the checkstyle plugin directly to the pom file of
shenyu-integrated-test ; )
Re: Why the parent module of shenyu-integrated-test is springboot?
Posted by Kunshuai Zhu <jo...@gmail.com>.
OK, I will do that~
David Liu <he...@apache.org> 于2021年7月28日周三 上午10:37写道：
>
> You can create an issue, and then prepare to make a pull request.
>
> David Liu <he...@apache.org> 于2021年7月28日周三 上午9:52写道：
>
> > I agree to replace spring-boot in pom file <parent> tag.
> >
> > KunShuai Zhu <jo...@gmail.com> 于2021年7月28日周三 上午12:32写道：
> >
> >> Hi community,
> >> I found that springboot is written in the <parent> tag in the pom.xml
> >> of the shenyu-integrated-test module. Shouldn't you fill in `shenyu`
> >> here? And this led to the lack of checkstyle in
> >> shenyu-integrated-test, which resulted in a lot of code style errors.
> >> If this is wrong, I can help to correct this, and then correct the
> >> code style error in shenyu-integrated-test. Or it should be springboot
> >> here, I can add the checkstyle plugin directly to the pom file of
> >> shenyu-integrated-test ; )
> >>
> >
Re: Why the parent module of shenyu-integrated-test is springboot?
Posted by David Liu <he...@apache.org>.
You can create an issue, and then prepare to make a pull request.
David Liu <he...@apache.org> 于2021年7月28日周三 上午9:52写道：
> I agree to replace spring-boot in pom file <parent> tag.
>
> KunShuai Zhu <jo...@gmail.com> 于2021年7月28日周三 上午12:32写道：
>
>> Hi community,
>> I found that springboot is written in the <parent> tag in the pom.xml
>> of the shenyu-integrated-test module. Shouldn't you fill in `shenyu`
>> here? And this led to the lack of checkstyle in
>> shenyu-integrated-test, which resulted in a lot of code style errors.
>> If this is wrong, I can help to correct this, and then correct the
>> code style error in shenyu-integrated-test. Or it should be springboot
>> here, I can add the checkstyle plugin directly to the pom file of
>> shenyu-integrated-test ; )
>>
>
Re: Why the parent module of shenyu-integrated-test is springboot?
Posted by David Liu <he...@apache.org>.
I agree to replace spring-boot in pom file <parent> tag.
KunShuai Zhu <jo...@gmail.com> 于2021年7月28日周三 上午12:32写道：
> Hi community,
> I found that springboot is written in the <parent> tag in the pom.xml
> of the shenyu-integrated-test module. Shouldn't you fill in `shenyu`
> here? And this led to the lack of checkstyle in
> shenyu-integrated-test, which resulted in a lot of code style errors.
> If this is wrong, I can help to correct this, and then correct the
> code style error in shenyu-integrated-test. Or it should be springboot
> here, I can add the checkstyle plugin directly to the pom file of
> shenyu-integrated-test ; )
>