You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/12/06 17:33:15 UTC
[PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]
snuyanzin opened a new pull request, #23885:
URL: https://github.com/apache/flink/pull/23885
## What is the purpose of the change
The PR is about to replace deprecated `StreamTableEnvironment#toAppendStream` with `StreamTableEnvironment#toDataStream` as mentioned in javadoc
## Brief change log
tests in table-planner
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]
Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #23885:
URL: https://github.com/apache/flink/pull/23885#discussion_r1417905005
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java:
##########
@@ -66,7 +66,7 @@ void testPassingExecutionParameters() {
// trigger translation
Table table = tEnv.sqlQuery("SELECT * FROM test");
- tEnv.toAppendStream(table, Row.class);
+ tEnv.toDataStream(table, Row.class);
Review Comment:
NIT: `tEnv.toDataStream(table)` should work too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23885:
URL: https://github.com/apache/flink/pull/23885#discussion_r1417994612
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java:
##########
@@ -66,7 +66,7 @@ void testPassingExecutionParameters() {
// trigger translation
Table table = tEnv.sqlQuery("SELECT * FROM test");
- tEnv.toAppendStream(table, Row.class);
+ tEnv.toDataStream(table, Row.class);
Review Comment:
yes, makes sense
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #23885:
URL: https://github.com/apache/flink/pull/23885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23885:
URL: https://github.com/apache/flink/pull/23885#issuecomment-1843366916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "19810b57dd41666d22a91399d41be0bc0c4794d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19810b57dd41666d22a91399d41be0bc0c4794d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19810b57dd41666d22a91399d41be0bc0c4794d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org