[GitHub] [ozone] siddhantsangwan commented on a change in pull request #3049: HDDS-6244. ContainerBalancer metrics don't show updated values in JMX

[GitBox <gi...@apache.org>]

siddhantsangwan commented on a change in pull request #3049:
URL: https://github.com/apache/ozone/pull/3049#discussion_r805666752



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java
##########
@@ -37,27 +36,16 @@
 
   private final MetricsSystem ms;
 
-  @Metric(about = "The total amount of used space in GigaBytes that needs to " +
-      "be balanced.")
-  private MutableGaugeLong dataSizeToBalanceGB;
+  @Metric(about = "The amount of Gigabytes that Container Balancer moved" +
+      " in the last iteration.")
+  private MutableCounterLong dataSizeMovedGB;
 
-  @Metric(about = "The amount of Giga Bytes that have been moved to achieve " +
-      "balance.")
-  private MutableGaugeLong dataSizeMovedGB;
+  @Metric(about = "Number of containers that Container Balancer moved" +
+      " in the last iteration.")
+  private MutableCounterLong movedContainersNum;

Review comment:
       Sure, I'll update the names. Aggregate metrics - you mean total no. of containers moved across iterations etc? For that we'll need to save container ids across iterations to avoid counting the same container multiple times.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org