You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/02 02:56:34 UTC

[GitHub] [arrow] westonpace opened a new pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

westonpace opened a new pull request #11294:
URL: https://github.com/apache/arrow/pull/11294


   While scanning we do our best to readahead multiple files so we will read files 1, 2, 3, and 4 all at the same time.  This helps to maintain bandwidth when some files hit a snag (sometimes happens on AWS).  However, when doing an ordered scan, this can cause backpressure to explode when there is a slow consumer.
   
   The sequencer (placed at the end of the pipeline) can get into a situation where it pulls aggressively from files 2, 3, and 4 while waiting for the next chunk from file 1.  Since the sequencer is consuming the batches the backpressure mechanism thinks they are being consumed.  However, the actual consumer is leaving the batches piling up at the sequencer.
   
   This PR introduces one possible solution (and it may be the only possible solution) which is to sequence the batches at merge time (early in the pipeline).  The sequencer won't need to pull aggressively and backpressure will be maintained.  This pretty significantly reduces (but does not eliminate) the amount of file readahead we do in ordered scans.  We can worry about that if it ends up being a bottleneck at some point but for now I think it is better we do not explode RAM.
   
   This builds on ARROW-13611 and will remain in draft until that PR has merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946193222


   Rebased and addressed PR comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731329143



##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -422,6 +422,42 @@ def test_scanner(dataset, dataset_reader):
     assert table.num_rows == scanner.count_rows()
 
 
+def test_scanner_backpressure():
+    batch = pa.record_batch([pa.array([1, 2, 3])], names=['data'])
+    num_read = 0
+    min_read = 64  # From kDefaultBackpressureHigh in scanner.h
+    end = 200
+
+    def counting_generator():
+        nonlocal num_read
+        while num_read < end:
+            time.sleep(0.01)
+            num_read += 1
+            yield batch
+
+    scanner = ds.Scanner.from_batches(
+        counting_generator(), batch.schema, use_threads=True, use_async=True)
+
+    _batch_iter = scanner.to_batches()  # This line starts the scan
+
+    start = time.time()
+
+    def duration():
+        return time.time() - start
+
+    last_num_read = 0
+    backpressure_probably_hit = False
+    while duration() < 10:
+        if num_read > min_read and num_read == last_num_read:
+            backpressure_probably_hit = True
+            break
+        last_num_read = num_read
+        time.sleep(0.5)

Review comment:
       If we do something like https://issues.apache.org/jira/browse/ARROW-14367 we can remove the timing dependency.  That being said, I understand the concern, and there was similar concern in the dataset write backpressure PR: https://github.com/apache/arrow/pull/11286#discussion_r728555922
   
   I will remove this test from this PR and rely on the existing python test.  When ARROW-14367 is implemented the timing dependency can be removed from the other test (and we can maybe reintroduce this test at that point).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731326001



##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -1175,8 +1179,15 @@ Result<compute::ExecNode*> MakeScanNode(compute::ExecPlan* plan,
   ARROW_ASSIGN_OR_RAISE(auto batch_gen_gen,
                         FragmentsToBatches(std::move(fragment_gen), scan_options));
 
-  auto merged_batch_gen =
-      MakeMergedGenerator(std::move(batch_gen_gen), scan_options->fragment_readahead);
+  AsyncGenerator<EnumeratedRecordBatch> merged_batch_gen;
+  if (require_sequenced_output) {
+    ARROW_ASSIGN_OR_RAISE(merged_batch_gen,
+                          MakeSequencedMergedGenerator(std::move(batch_gen_gen),
+                                                       scan_options->fragment_readahead));

Review comment:
       Ah, indeed, you're right. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace closed pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #11294:
URL: https://github.com/apache/arrow/pull/11294


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-932670036






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946342917


   Benchmark runs are scheduled for baseline = f2f663be0a87e13c9cd5403dea51379deb4cf04d and contender = 9abd2b140813dfa941a592764ea07d38d2f0644e. 9abd2b140813dfa941a592764ea07d38d2f0644e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b557e9d7ecf475aa5994d697ce6d05e...aba975bddbc940ceb08491d8e5687ed3/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/936d3a66840e49fc87988b3ae9ac8d25...ce938484130d40c19153d605d377a2c0/)
   [Finished :arrow_down:0.4% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/62b718ae16a64feead06fc207e71faea...b7dc6303e083457494557b6856992323/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731323572



##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -1175,8 +1179,15 @@ Result<compute::ExecNode*> MakeScanNode(compute::ExecPlan* plan,
   ARROW_ASSIGN_OR_RAISE(auto batch_gen_gen,
                         FragmentsToBatches(std::move(fragment_gen), scan_options));
 
-  auto merged_batch_gen =
-      MakeMergedGenerator(std::move(batch_gen_gen), scan_options->fragment_readahead);
+  AsyncGenerator<EnumeratedRecordBatch> merged_batch_gen;
+  if (require_sequenced_output) {
+    ARROW_ASSIGN_OR_RAISE(merged_batch_gen,
+                          MakeSequencedMergedGenerator(std::move(batch_gen_gen),
+                                                       scan_options->fragment_readahead));

Review comment:
       No, it is not redundant.  We still need to resequence at the end (currently MakeSequencingGenerator is used after the plan) because there is no guarantee operations like filter or project will maintain the ordering.  Although, we could introduce a sequenced sink which would allow us to get rid of MakeSequencingGenerator.  We can tackle that when we tackle general sequencing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946342917


   Benchmark runs are scheduled for baseline = f2f663be0a87e13c9cd5403dea51379deb4cf04d and contender = 9abd2b140813dfa941a592764ea07d38d2f0644e. 9abd2b140813dfa941a592764ea07d38d2f0644e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b557e9d7ecf475aa5994d697ce6d05e...aba975bddbc940ceb08491d8e5687ed3/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/936d3a66840e49fc87988b3ae9ac8d25...ce938484130d40c19153d605d377a2c0/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/62b718ae16a64feead06fc207e71faea...b7dc6303e083457494557b6856992323/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946342917


   Benchmark runs are scheduled for baseline = f2f663be0a87e13c9cd5403dea51379deb4cf04d and contender = 9abd2b140813dfa941a592764ea07d38d2f0644e. 9abd2b140813dfa941a592764ea07d38d2f0644e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b557e9d7ecf475aa5994d697ce6d05e...aba975bddbc940ceb08491d8e5687ed3/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/936d3a66840e49fc87988b3ae9ac8d25...ce938484130d40c19153d605d377a2c0/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/62b718ae16a64feead06fc207e71faea...b7dc6303e083457494557b6856992323/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946474635


   @westonpace It seems that "C++ / AMD64 Ubuntu 20.04 C++ ASAN UBSAN" is failed by this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946342174


   CI failures are unrelated (could not find LLVM) and these tests passed on earlier versions.  I will proceed with merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731284492



##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -422,6 +422,42 @@ def test_scanner(dataset, dataset_reader):
     assert table.num_rows == scanner.count_rows()
 
 
+def test_scanner_backpressure():
+    batch = pa.record_batch([pa.array([1, 2, 3])], names=['data'])
+    num_read = 0
+    min_read = 64  # From kDefaultBackpressureHigh in scanner.h
+    end = 200
+
+    def counting_generator():
+        nonlocal num_read
+        while num_read < end:
+            time.sleep(0.01)
+            num_read += 1
+            yield batch
+
+    scanner = ds.Scanner.from_batches(
+        counting_generator(), batch.schema, use_threads=True, use_async=True)
+
+    _batch_iter = scanner.to_batches()  # This line starts the scan
+
+    start = time.time()
+
+    def duration():
+        return time.time() - start
+
+    last_num_read = 0
+    backpressure_probably_hit = False
+    while duration() < 10:
+        if num_read > min_read and num_read == last_num_read:
+            backpressure_probably_hit = True
+            break
+        last_num_read = num_read
+        time.sleep(0.5)

Review comment:
       I suppose we have a good number of these now, but timing-based tests always make me feel somewhat icky. Is there value to testing this in Python as well as C++?

##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -711,6 +711,26 @@ AsyncGenerator<T> MakeSerialReadaheadGenerator(AsyncGenerator<T> source_generato
   return SerialReadaheadGenerator<T>(std::move(source_generator), max_readahead);
 }
 
+template <typename T>

Review comment:
       nit: add a doc comment like for the others? This is an "eagerly evaluated" ("hot" I think ReactiveX calls it?) generator?

##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -1175,8 +1179,15 @@ Result<compute::ExecNode*> MakeScanNode(compute::ExecPlan* plan,
   ARROW_ASSIGN_OR_RAISE(auto batch_gen_gen,
                         FragmentsToBatches(std::move(fragment_gen), scan_options));
 
-  auto merged_batch_gen =
-      MakeMergedGenerator(std::move(batch_gen_gen), scan_options->fragment_readahead);
+  AsyncGenerator<EnumeratedRecordBatch> merged_batch_gen;
+  if (require_sequenced_output) {
+    ARROW_ASSIGN_OR_RAISE(merged_batch_gen,
+                          MakeSequencedMergedGenerator(std::move(batch_gen_gen),
+                                                       scan_options->fragment_readahead));

Review comment:
       (Though I suppose it shouldn't hurt.)

##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -1156,6 +1176,23 @@ AsyncGenerator<T> MakeMergedGenerator(AsyncGenerator<AsyncGenerator<T>> source,
   return MergedGenerator<T>(std::move(source), max_subscriptions);
 }
 
+template <typename T>
+Result<AsyncGenerator<T>> MakeSequencedMergedGenerator(
+    AsyncGenerator<AsyncGenerator<T>> source, int max_subscriptions) {
+  if (max_subscriptions < 0) {
+    return Status::Invalid("max_subscriptions must be a positive integer");
+  }
+  if (max_subscriptions == 1) {
+    return Status::Invalid("Use MakeConcatenatedGenerator is max_subscriptions is 1");

Review comment:
       ```suggestion
       return Status::Invalid("Use MakeConcatenatedGenerator if max_subscriptions is 1");
   ```

##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -1156,6 +1176,23 @@ AsyncGenerator<T> MakeMergedGenerator(AsyncGenerator<AsyncGenerator<T>> source,
   return MergedGenerator<T>(std::move(source), max_subscriptions);
 }
 
+template <typename T>
+Result<AsyncGenerator<T>> MakeSequencedMergedGenerator(

Review comment:
       So just to make sure I get this right, this will "kick off" some number of sub-generators (so they start doing work), but will only actually pull from the first one (so the others shouldn't queue up too much)?

##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -1175,8 +1179,15 @@ Result<compute::ExecNode*> MakeScanNode(compute::ExecPlan* plan,
   ARROW_ASSIGN_OR_RAISE(auto batch_gen_gen,
                         FragmentsToBatches(std::move(fragment_gen), scan_options));
 
-  auto merged_batch_gen =
-      MakeMergedGenerator(std::move(batch_gen_gen), scan_options->fragment_readahead);
+  AsyncGenerator<EnumeratedRecordBatch> merged_batch_gen;
+  if (require_sequenced_output) {
+    ARROW_ASSIGN_OR_RAISE(merged_batch_gen,
+                          MakeSequencedMergedGenerator(std::move(batch_gen_gen),
+                                                       scan_options->fragment_readahead));

Review comment:
       Does this mean MakeSequencingGenerator is now redundant, since we pull from subgenerators sequentially?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731338879



##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -422,6 +422,42 @@ def test_scanner(dataset, dataset_reader):
     assert table.num_rows == scanner.count_rows()
 
 
+def test_scanner_backpressure():
+    batch = pa.record_batch([pa.array([1, 2, 3])], names=['data'])
+    num_read = 0
+    min_read = 64  # From kDefaultBackpressureHigh in scanner.h
+    end = 200
+
+    def counting_generator():
+        nonlocal num_read
+        while num_read < end:
+            time.sleep(0.01)
+            num_read += 1
+            yield batch
+
+    scanner = ds.Scanner.from_batches(
+        counting_generator(), batch.schema, use_threads=True, use_async=True)
+
+    _batch_iter = scanner.to_batches()  # This line starts the scan
+
+    start = time.time()
+
+    def duration():
+        return time.time() - start
+
+    last_num_read = 0
+    backpressure_probably_hit = False
+    while duration() < 10:
+        if num_read > min_read and num_read == last_num_read:
+            backpressure_probably_hit = True
+            break
+        last_num_read = num_read
+        time.sleep(0.5)

Review comment:
       The test has been removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731321783



##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -1156,6 +1176,23 @@ AsyncGenerator<T> MakeMergedGenerator(AsyncGenerator<AsyncGenerator<T>> source,
   return MergedGenerator<T>(std::move(source), max_subscriptions);
 }
 
+template <typename T>
+Result<AsyncGenerator<T>> MakeSequencedMergedGenerator(

Review comment:
       Yes.  After implementing it I realized it may be a bit of a premature optimization (we could probably just use a concatenated generator) but it will do exactly as you describe.  So it has a slight advantage over the concatenated generator in that it "primes" future generators even if it doesn't start reading from them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#discussion_r731338714



##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -711,6 +711,26 @@ AsyncGenerator<T> MakeSerialReadaheadGenerator(AsyncGenerator<T> source_generato
   return SerialReadaheadGenerator<T>(std::move(source_generator), max_readahead);
 }
 
+template <typename T>

Review comment:
       Added, thanks for the catch.  I also realized our grammar was a bit mixed on these comments so I cleaned that up which introduced a bit of noise to the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11294: ARROW-14192: [C++][Dataset] Backpressure broken on ordered scans

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11294:
URL: https://github.com/apache/arrow/pull/11294#issuecomment-946342917


   Benchmark runs are scheduled for baseline = f2f663be0a87e13c9cd5403dea51379deb4cf04d and contender = 9abd2b140813dfa941a592764ea07d38d2f0644e. 9abd2b140813dfa941a592764ea07d38d2f0644e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b557e9d7ecf475aa5994d697ce6d05e...aba975bddbc940ceb08491d8e5687ed3/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/936d3a66840e49fc87988b3ae9ac8d25...ce938484130d40c19153d605d377a2c0/)
   [Finished :arrow_down:0.4% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/62b718ae16a64feead06fc207e71faea...b7dc6303e083457494557b6856992323/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org