You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "werner mueller (JIRA)" <ji...@codehaus.org> on 2007/08/15 20:02:47 UTC

[jira] Created: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

plugin uses artifactId in multi module builds, regardeless of the module name
-----------------------------------------------------------------------------

                 Key: MCHANGELOG-75
                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
             Project: Maven 2.x Changelog Plugin
          Issue Type: Improvement
    Affects Versions: 2.0
         Environment: linux, java 1.4, maven 2.0.7
            Reporter: werner mueller


hallo

in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.

we have:
parentpom.xml
 - module.a.core.stuff (artifactId module-a-core-stuff)
 - module.b.core.things (artifactId module-b-core-stuff)
 - ...

the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)

the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)

i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.

thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Michael Semb Wever (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149382#action_149382 ] 

michaelwever edited comment on MCHANGELOG-75 at 9/30/08 8:39 AM:
-----------------------------------------------------------------------

If it's in DefaultModelInheritanceAssembler.java then this issue should be moved to "Maven Project Builder" ?

--> http://jira.codehaus.org/browse/MNG


      was (Author: michaelwever):
    If it's in DefaultModelInheritanceAssembler.java then this issue should be moved to "Maven Project Builder" ?
  
> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Michael Semb Wever (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149382#action_149382 ] 

Michael Semb Wever commented on MCHANGELOG-75:
----------------------------------------------

If it's in DefaultModelInheritanceAssembler.java then this issue should be moved to "Maven Project Builder" ?

> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Damien Lecan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115201 ] 

Damien Lecan commented on MCHANGELOG-75:
----------------------------------------

Same problem for me, with changelog-plugin 2.1

The plugin tries to use artifactId instead of module name

> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Moved: (MNG-4670) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg moved MCHANGELOG-75 to MNG-4670:
------------------------------------------------

           Complexity: Intermediate
    Affects Version/s:     (was: 2.0)
                  Key: MNG-4670  (was: MCHANGELOG-75)
              Project: Maven 2 & 3  (was: Maven 2.x Changelog Plugin)

> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MNG-4670
>                 URL: http://jira.codehaus.org/browse/MNG-4670
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Felix Knecht (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126019 ] 

Felix Knecht commented on MCHANGELOG-75:
----------------------------------------

I think the problem is in https://svn.apache.org/repos/asf/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java

It uses artifactId to generate the repository path instead of the module name.

private void assembleScmInheritance( Model child, Model parent, String childPathAdjustment, boolean appendPaths )
    {
        if ( parent.getScm() != null )
        {
            Scm parentScm = parent.getScm();

            Scm childScm = child.getScm();

            if ( childScm == null )
            {
                childScm = new Scm();

                child.setScm( childScm );
            }

            if ( StringUtils.isEmpty( childScm.getConnection() ) && !StringUtils.isEmpty( parentScm.getConnection() ) )
            {
                childScm.setConnection(
                    appendPath( parentScm.getConnection(), child.getArtifactId(), childPathAdjustment, appendPaths ) );
            }

            if ( StringUtils.isEmpty( childScm.getDeveloperConnection() ) &&
                !StringUtils.isEmpty( parentScm.getDeveloperConnection() ) )
            {
                childScm
                    .setDeveloperConnection( appendPath( parentScm.getDeveloperConnection(), child.getArtifactId(),
                                                         childPathAdjustment, appendPaths ) );
            }

            if ( StringUtils.isEmpty( childScm.getUrl() ) && !StringUtils.isEmpty( parentScm.getUrl() ) )
            {
                childScm.setUrl(
                    appendPath( parentScm.getUrl(), child.getArtifactId(), childPathAdjustment, appendPaths ) );
            }
        }
    }


> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4670) SCM uses artifactId in multi module builds, regardeless of the module name

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MNG-4670:
---------------------------------

    Component/s: Inheritance and Interpolation
        Summary: SCM uses artifactId in multi module builds, regardeless of the module name  (was: plugin uses artifactId in multi module builds, regardeless of the module name)

> SCM uses artifactId in multi module builds, regardeless of the module name
> --------------------------------------------------------------------------
>
>                 Key: MNG-4670
>                 URL: http://jira.codehaus.org/browse/MNG-4670
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104943 ] 

Dennis Lundberg commented on MCHANGELOG-75:
-------------------------------------------

I think that this issue really belongs in maven-scm, but first let us see if it hasn't been fixed already.

Please upgrade to version 2.1 of maven-changelog-plugin and try again. It has lots of fixes and, most importantly, uses maven-scm-1.0.

> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGELOG-75) plugin uses artifactId in multi module builds, regardeless of the module name

Posted by "Michael Semb Wever (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGELOG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149412#action_149412 ] 

Michael Semb Wever commented on MCHANGELOG-75:
----------------------------------------------

Looks like it's MNG-2006

> plugin uses artifactId in multi module builds, regardeless of the module name
> -----------------------------------------------------------------------------
>
>                 Key: MCHANGELOG-75
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-75
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: linux, java 1.4, maven 2.0.7
>            Reporter: werner mueller
>
> hallo
> in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.
> we have:
> parentpom.xml
>  - module.a.core.stuff (artifactId module-a-core-stuff)
>  - module.b.core.things (artifactId module-b-core-stuff)
>  - ...
> the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)
> the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)
> i would like some configuration option in the parent pom to define what name shall be used (${project.artifactId} or ${project.name} for example). so the module name can be matched if it is not the same as the artifactId.
> thanks :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira