[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3909: [Bug] [Seatunnel-Engine] Fix when sub plan scheduling fails a NPE will happen.

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3909:
URL: https://github.com/apache/incubator-seatunnel/pull/3909#discussion_r1067657714


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/scheduler/PipelineBaseScheduler.java:
##########
@@ -99,6 +101,8 @@ private CompletableFuture<Void> schedulerPipeline(SubPlan pipeline) {
                 deployPipeline(pipeline, slotProfiles);
             }, jobMaster.getExecutorService());
         } catch (Exception e) {
+            log.error(String.format("scheduler pipeline [%s] error and cancel pipeline. The error is %s",

Review Comment:
   ```
   log.error(String.format("scheduler %s error and cancel pipeline. The error is %s"), pipeline.getPipelineFullName(), ExceptionUtils.getMessage(e)) 
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org