[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3793: Make RrocksDB checksum type configurable

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #3793:
URL: https://github.com/apache/bookkeeper/pull/3793#discussion_r1126008070


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDBTest.java:
##########
@@ -78,4 +80,38 @@ public void testRocksDBInitiateWithConfigurationFile() throws Exception {
         assertEquals(1, familyOptions.maxWriteBufferNumber());
         rocksDB.close();
     }
+
+    @Test
+    public void testReadChecksumTypeFromBookieConfiguration() throws Exception {
+        ServerConfiguration configuration = new ServerConfiguration();
+        configuration.setProperty("dbStorage_rocksDB_checksum_type", "kxxHash");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org