You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Francisco Gimeno <ki...@kikov.org> on 2007/08/23 20:42:39 UTC

[PATCH 43167] Adding status=i|I (Ignore Errors) option for ProxyPass

Hello,

I have made a tiny patch for Apache 2.2 mod_proxy. It consists on enabling a
new option to status parameter in ProxyPass directive.

My idea is that I don't want to disable a destination server whenever a
single failure occur though it could be just for 1second (retry=1).
I have done this to get the same behaviour than 2.0 version though I have to
add the "status=i" to all the ProxyPass.

Could anybody confirm that:
- it works well: in my tests it seems, but I don't know have test cases
here.
- it's the right way to do it: as the code seems prepared to do it, I have
just enabled in the config parser.

comments? is there a better way to do this?

Thanks

Regards,
Francisco Gimeno

Re: [PATCH 43167] Adding status=i|I (Ignore Errors) option for ProxyPass

Posted by Francisco Gimeno <ki...@kikov.org>.
the URL, http://issues.apache.org/bugzilla/attachment.cgi?id=20681

anyway, it's tiny:
------------

diff -ur apache2-2.2.4.orig/modules/proxy/mod_proxy.c
apache2-2.2.4.kikov1/modules/proxy/mod_proxy.c
--- apache2-2.2.4.orig/modules/proxy/mod_proxy.c	2006-11-27
16:00:56.000000000 +0100
+++ apache2-2.2.4.kikov1/modules/proxy/mod_proxy.c	2007-08-20
15:17:46.000000000 +0200
@@ -219,6 +219,12 @@
                 else
                     worker->status &= ~PROXY_WORKER_HOT_STANDBY;
             }
+	    else if (*v == 'I' || *v == 'i') {
+	    	if (mode)
+		    worker->status |= PROXY_WORKER_IGNORE_ERRORS;
+		else
+		    worker->status &= ~PROXY_WORKER_IGNORE_ERRORS;
+	    }
             else {
                 return "Unknown status parameter option";
             }
---------

Thanks for the feedback!


Francisco,
>
> I don't see the patch. Can you provide a URL for it?
> Or, if small, add to your reply?
>
> Thanks!
>

Re: [PATCH 43167] Adding status=i|I (Ignore Errors) option for ProxyPass

Posted by Jim Jagielski <ji...@jaguNET.com>.
On Aug 23, 2007, at 2:42 PM, Francisco Gimeno wrote:

> Hello,
>
> I have made a tiny patch for Apache 2.2 mod_proxy. It consists on  
> enabling a new option to status parameter in ProxyPass directive.
>
> My idea is that I don't want to disable a destination server  
> whenever a single failure occur though it could be just for 1second  
> (retry=1).
> I have done this to get the same behaviour than 2.0 version though  
> I have to add the "status=i" to all the ProxyPass.
>
> Could anybody confirm that:
> - it works well: in my tests it seems, but I don't know have test  
> cases here.
> - it's the right way to do it: as the code seems prepared to do it,  
> I have just enabled in the config parser.
>
> comments? is there a better way to do this?
>
> Thanks
>
> Regards,
> Francisco Gimeno

Francisco,

I don't see the patch. Can you provide a URL for it?
Or, if small, add to your reply?

Thanks!