You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 01:12:05 UTC
[GitHub] [airflow] mik-laj opened a new pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
mik-laj opened a new pull request #20245:
URL: https://github.com/apache/airflow/pull/20245
The snowflake-alchemy 1.2.5 introduces a hard dependency on `sqlalchemy>=1.4.0`, but they didn't define this requirement in setup.py, so pip cannot figure out the correct set of dependencies.
See: https://github.com/snowflakedb/snowflake-sqlalchemy/issues/234
This release should have been marked [yanked](https://www.python.org/dev/peps/pep-0592/), but Snowflake has not yet done so.
CC: @sfc-gh-abhatnagar @harishkrao
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
pip install `apache-airflow[snowflake]` -c `https://github.com/apache/airflow/blob/62d490d4da17e35d4ddcd4ee38902a8a4e9bbfff/constraints-3.7.txt`
It still results in the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011580548
@potiuk @mik-laj Can we also fix the constraints for airflow `2.2.3`? It looks like `snowflake-sqlalchemy` is set to `1.2.5` [here](https://github.com/apache/airflow/blob/62d490d4da17e35d4ddcd4ee38902a8a4e9bbfff/constraints-3.7.txt#L485).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011580548
@potiuk @mik-laj Can we also fix the constraints for airflow `2.2.3`? It looks like `snowflake-sqlalchemy` is still set to `1.2.5` [here](https://github.com/apache/airflow/blob/62d490d4da17e35d4ddcd4ee38902a8a4e9bbfff/constraints-3.7.txt#L485).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011849274
https://github.com/apache/airflow/blob/constraints-2.2.3/constraints-3.7.txt#L485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1012171989
@potiuk Thanks for the quick turnaround on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
```
pip install `apache-airflow[snowflake]==2.2.3` -c `https://raw.githubusercontent.com/apache/airflow/constraints-2.2.3/constraints-3.7.txt`
```
It still results in the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992305671
This one will need to get constraints regenerated quickly after merge as this will generate conflicts with main constraints. Let me do it now and I can merge/push constraints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20245:
URL: https://github.com/apache/airflow/pull/20245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing
pip install `apache-airflow[snowflake]` -c `https://github.com/apache/airflow/blob/62d490d4da17e35d4ddcd4ee38902a8a4e9bbfff/constraints-3.7.txt` it will cause the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992169823
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes removed a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes removed a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011561961
https://github.com/apache/airflow/pull/20245#issuecomment-992387108
Can we please fix the constraints for 2.2.3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011599004
@NadimYounes This release has been yanked, so it shouldn't be installed automatically anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
pip install `apache-airflow[snowflake]` -c `https://raw.githubusercontent.com/apache/airflow/constraints-2.2.3/constraints-3.7.txt`
It still results in the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011848901
@NadimYounes -Indeed 2.2.3 constraints were prepared before snowflake was yanked. It should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
pip install `apache-airflow[snowflake]==2.2.3` -c `https://raw.githubusercontent.com/apache/airflow/constraints-2.2.3/constraints-3.7.txt`
It still results in the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992310839
Also @mik-laj -> I believe we should fix constraints for released airlfow version - snowflake sqlalchemy 1.2.5 is used in all constraints - 2.1.3, 2.1.4, 2.2.0, 2.2.1, 2.2.2. I guess we should downgrade those to 1.2.4 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992387108
I updated the updated constraints (snowflake-sqlalchemy = 1.2.4) for Airlfow 2.2.2 and 2.1.4. I think this is the right way to go - we should encourage people to go to the highest patchlevels anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes edited a comment on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes edited a comment on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011631448
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
```
pip install apache-airflow[snowflake]==2.2.3 -c https://raw.githubusercontent.com/apache/airflow/constraints-2.2.3/constraints-3.7.txt
```
It still results in the known issues with SqlAlchemy imports. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992351737
Constraints updated in main. Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992307146
I will also cherry-pick that one to 2.2.3 @jedcunningham
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
NadimYounes commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-1011561961
https://github.com/apache/airflow/pull/20245#issuecomment-992387108
Can we please fix the constraints for 2.2.3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992316059
Generating the constraints now -> I will be back in ~ 1.5 h and I will merge/push constraints then (getting 3rd vaccination in 30 mins :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20245: Exclude snowflake-sqlalchemy v1.2.5
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20245:
URL: https://github.com/apache/airflow/pull/20245#issuecomment-992389303
We should actually even release an ad-hoc release of the snowflake Provider with those limitiations. I will take a look at that after we release the databricks one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org