You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 11:04:00 UTC
[GitHub] [arrow] js8544 opened a new pull request, #14109: ARROW 17703: [C++][Gandiva][Build]Fix Gandiva OpenSSL dependency
js8544 opened a new pull request, #14109:
URL: https://github.com/apache/arrow/pull/14109
If I build gandiva alone, I get a link error saying OpenSSL related definitions are not found. After some digging, I found out that `ARROW_USE_OPENSSL` is only turned on if any of the following conditions is met: `PARQUET_REQUIRE_ENCRYPTION`, `ARROW_FLIGHT`, `ARROW_S3`. Adding `ARROW_GANDIVA` to the list solves this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14109: ARROW-17703: [C++][Gandiva] Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14109:
URL: https://github.com/apache/arrow/pull/14109#issuecomment-1246304866
Benchmark runs are scheduled for baseline = 01dce6a0c95242224eab1a5331e0a2524a4b9339 and contender = 7c7fbcfaf34463121fa51a8b51771d814ffd1fdf. 7c7fbcfaf34463121fa51a8b51771d814ffd1fdf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/786199f5e865403ca6420d735497eec4...120732c982d643b28687e299171f6da3/)
[Failed :arrow_down:0.48% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9d9605b09a5f4faaa60e033fa9db0608...dc2b63aac6fa40e8bfc3bd1adf9e03ec/)
[Failed :arrow_down:0.56% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/86ee47d5a5334c20939f1db990880c9f...22d7296f04f4496a9b5eb1d758fa265e/)
[Finished :arrow_down:0.53% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e7095196592048de8164f31bb5e10b35...e0148966fcae4dcfa4cc58dbb0ea110c/)
Buildkite builds:
[Finished] [`7c7fbcfa` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1467)
[Failed] [`7c7fbcfa` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1483)
[Failed] [`7c7fbcfa` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1467)
[Finished] [`7c7fbcfa` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1480)
[Finished] [`01dce6a0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1466)
[Finished] [`01dce6a0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1482)
[Failed] [`01dce6a0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1466)
[Finished] [`01dce6a0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1479)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14109: ARROW-17703: [C++][Gandiva][Build]Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14109:
URL: https://github.com/apache/arrow/pull/14109#issuecomment-1245289046
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14109: ARROW-17703: [C++][Gandiva] Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
kou merged PR #14109:
URL: https://github.com/apache/arrow/pull/14109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14109: ARROW-17703: [C++][Gandiva][Build] Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14109:
URL: https://github.com/apache/arrow/pull/14109#issuecomment-1245313411
https://issues.apache.org/jira/browse/ARROW-17703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #14109: ARROW-17703: [C++][Gandiva] Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
js8544 commented on PR #14109:
URL: https://github.com/apache/arrow/pull/14109#issuecomment-1245380405
> Could you remove `find_package(OpenSSLAlt)` in `cpp/src/gandiva/CMakeLists.txt`?
>
> ```diff
> diff --git a/cpp/src/gandiva/CMakeLists.txt b/cpp/src/gandiva/CMakeLists.txt
> index 3794b7a6c4..e69844d99a 100644
> --- a/cpp/src/gandiva/CMakeLists.txt
> +++ b/cpp/src/gandiva/CMakeLists.txt
> @@ -40,8 +40,6 @@ endif()
>
> add_definitions(-DGANDIVA_LLVM_VERSION=${LLVM_VERSION_MAJOR})
>
> -find_package(OpenSSLAlt REQUIRED)
> -
> # Set the path where the bitcode file generated, see precompiled/CMakeLists.txt
> set(GANDIVA_PRECOMPILED_BC_PATH "${CMAKE_CURRENT_BINARY_DIR}/irhelpers.bc")
> set(GANDIVA_PRECOMPILED_CC_PATH "${CMAKE_CURRENT_BINARY_DIR}/precompiled_bitcode.cc")
> ```
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14109: ARROW-17703: [C++][Gandiva] Fix Gandiva OpenSSL dependency
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14109:
URL: https://github.com/apache/arrow/pull/14109#issuecomment-1245377059
Could you remove `find_package(OpenSSLAlt)` in `cpp/src/gandiva/CMakeLists.txt`?
```diff
diff --git a/cpp/src/gandiva/CMakeLists.txt b/cpp/src/gandiva/CMakeLists.txt
index 3794b7a6c4..e69844d99a 100644
--- a/cpp/src/gandiva/CMakeLists.txt
+++ b/cpp/src/gandiva/CMakeLists.txt
@@ -40,8 +40,6 @@ endif()
add_definitions(-DGANDIVA_LLVM_VERSION=${LLVM_VERSION_MAJOR})
-find_package(OpenSSLAlt REQUIRED)
-
# Set the path where the bitcode file generated, see precompiled/CMakeLists.txt
set(GANDIVA_PRECOMPILED_BC_PATH "${CMAKE_CURRENT_BINARY_DIR}/irhelpers.bc")
set(GANDIVA_PRECOMPILED_CC_PATH "${CMAKE_CURRENT_BINARY_DIR}/precompiled_bitcode.cc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org