You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2016/11/07 23:10:09 UTC
[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1765
STORM-2190: reduce contention between submission and scheduling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2190-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1765
----
commit 5eb639149a60f3059065c0e47fd128c4212b239b
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2016-11-07T23:08:07Z
STORM-2190: reduce contention between submission and scheduling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1765: STORM-2190: reduce contention between submission and sche...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1765
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1765: STORM-2190: reduce contention between submission and sche...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1765
One question about the for loop in WordCountTopology. I'm +1 once that's answered/addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1765#discussion_r90465747
--- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java ---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws Exception {
if (args != null && args.length > 0) {
conf.setNumWorkers(3);
- StormSubmitter.submitTopologyWithProgressBar(args[0], conf, builder.createTopology());
+ for (String name: args) {
--- End diff --
This was code that I put in to be able to reproduce the problem consistently. If you want me to remove it I am happy to. It does not really provide any real value beyond that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1765
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1765#discussion_r90534501
--- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java ---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws Exception {
if (args != null && args.length > 0) {
conf.setNumWorkers(3);
- StormSubmitter.submitTopologyWithProgressBar(args[0], conf, builder.createTopology());
+ for (String name: args) {
--- End diff --
I'd say remove it. My reasoning is that it's an example, and new users might get confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1765#discussion_r90317167
--- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java ---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws Exception {
if (args != null && args.length > 0) {
conf.setNumWorkers(3);
- StormSubmitter.submitTopologyWithProgressBar(args[0], conf, builder.createTopology());
+ for (String name: args) {
--- End diff --
I'm not sure I understand the for loop here. Isn't this change just submitting the same topology multiple times with different names? Is this an artifact from manual testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---