You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by bi...@apache.org on 2014/03/12 23:08:32 UTC
git commit: [flex-sdk] [refs/heads/develop] - Fix for
https://issues.apache.org/jira/browse/FLEX-34139 Adjusted scale values of FXG
elements so that they look good at 120DPI.
Repository: flex-sdk
Updated Branches:
refs/heads/develop aeb0b392c -> 5ab4cbaf4
Fix for https://issues.apache.org/jira/browse/FLEX-34139
Adjusted scale values of FXG elements so that they look good at 120DPI.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5ab4cbaf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5ab4cbaf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5ab4cbaf
Branch: refs/heads/develop
Commit: 5ab4cbaf425d2ac374d6f5fd74762819f0d4b269
Parents: aeb0b39
Author: Om <bi...@gmail.com>
Authored: Wed Mar 12 15:07:16 2014 -0700
Committer: Om <bi...@gmail.com>
Committed: Wed Mar 12 15:07:16 2014 -0700
----------------------------------------------------------------------
.../TabbedViewNavigatorButtonBarFirstButton_down.fxg | 12 ++++++------
...bbedViewNavigatorButtonBarFirstButton_selected.fxg | 12 ++++++------
.../TabbedViewNavigatorButtonBarFirstButton_up.fxg | 12 ++++++------
.../TabbedViewNavigatorButtonBarLastButton_down.fxg | 14 +++++++-------
...abbedViewNavigatorButtonBarLastButton_selected.fxg | 14 +++++++-------
.../TabbedViewNavigatorButtonBarLastButton_up.fxg | 14 +++++++-------
6 files changed, 39 insertions(+), 39 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg
index 94c4d2e..d385532 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="0" y="2" width="120" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="120" height="72">
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#000000" ratio="0" alpha=".3"/>
@@ -29,25 +29,25 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="0.5" y="2.5" width="119" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="0.5" y="2.5" width="119" height="71">
<stroke>
<SolidColorStroke color="#000000" weight="1" alpha=".1"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_selected.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_selected.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_selected.fxg
index 5471186..074f18f 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_selected.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_selected.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="0" y="2" width="120" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="120" height="72">
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#000000" ratio="0" alpha=".05"/>
@@ -29,25 +29,25 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="0.5" y="2.5" width="119" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="0.5" y="2.5" width="119" height="71">
<stroke>
<SolidColorStroke color="#000000" weight="1" alpha=".1"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_up.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_up.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_up.fxg
index f3e199f..5a37f1b 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_up.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarFirstButton_up.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="0" y="2" width="120" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="120" height="72" >
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#ffffff" ratio="0" alpha=".2"/>
@@ -29,25 +29,25 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="0.5" y="2.5" width="119" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="0.5" y="2.5" width="119" height="71">
<stroke>
<SolidColorStroke color="#ffffff" weight="1" alpha=".2"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_down.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_down.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_down.fxg
index 255c3a6..a4f7306 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_down.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_down.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="2" y="2" width="118" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="2" y="2" width="118" height="72">
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#000000" ratio="0" alpha=".3"/>
@@ -29,31 +29,31 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border left -->
- <Rect x="0" y="2" width="2" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="2" height="72">
<fill>
<SolidColor color="#000000" alpha="0.8"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="2.5" y="2.5" width="117" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="2.5" y="2.5" width="117" height="71">
<stroke>
<SolidColorStroke color="#000000" weight="1" alpha=".1"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_selected.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_selected.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_selected.fxg
index 92b3e07..d27a32c 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_selected.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_selected.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="2" y="2" width="118" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="2" y="2" width="118" height="72">
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#000000" ratio="0" alpha=".05"/>
@@ -29,31 +29,31 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border left -->
- <Rect x="0" y="2" width="2" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="2" height="72">
<fill>
<SolidColor color="#000000" alpha="0.8"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="2.5" y="2.5" width="117" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="2.5" y="2.5" width="117" height="71">
<stroke>
<SolidColorStroke color="#000000" weight="1" alpha=".1"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ab4cbaf/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_up.fxg
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_up.fxg b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_up.fxg
index 800b592..19e1b97 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_up.fxg
+++ b/frameworks/projects/mobiletheme/src/spark/skins/mobile120/assets/TabbedViewNavigatorButtonBarLastButton_up.fxg
@@ -18,9 +18,9 @@
-->
-<Graphic version="2.0" scaleGridTop="4" scaleGridBottom="72" scaleGridLeft="3" scaleGridRight="117" xmlns="http://ns.adobe.com/fxg/2008">
+<Graphic version="2.0" scaleGridTop="1" scaleGridBottom="75" scaleGridLeft="6" scaleGridRight="114" xmlns="http://ns.adobe.com/fxg/2008">
<!-- highlight fill -->
- <Rect x="2" y="2" width="118" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="2" y="2" width="118" height="72">
<fill>
<LinearGradient x="0" scaleX="72" rotation="90">
<GradientEntry color="#ffffff" ratio="0" alpha=".2"/>
@@ -29,31 +29,31 @@
</fill>
</Rect>
<!-- border top -->
- <Rect x="0" y="0" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border bottom -->
- <Rect x="0" y="74" width="120" height="2" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="74" width="120" height="2">
<fill>
<SolidColor color="#000000" alpha="0.75"/>
</fill>
</Rect>
<!-- border left -->
- <Rect x="0" y="2" width="2" height="72" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="2" width="2" height="72">
<fill>
<SolidColor color="#000000" alpha="0.8"/>
</fill>
</Rect>
<!-- highlight stroke -->
- <Rect x="2.5" y="2.5" width="117" height="71" scaleX="0.5" scaleY="0.5">
+ <Rect x="2.5" y="2.5" width="117" height="71">
<stroke>
<SolidColorStroke color="#ffffff" weight="1" alpha=".2"/>
</stroke>
</Rect>
<!-- scaling fix -->
- <Rect x="0" y="0" width="120" height="76" scaleX="0.5" scaleY="0.5">
+ <Rect x="0" y="0" width="120" height="76">
<fill>
<SolidColor color="#000000" alpha="0"/>
</fill>
Re: git commit: [flex-sdk] [refs/heads/develop] - Fix for https://issues.apache.org/jira/browse/FLEX-34139 Adjusted scale values of FXG elements so that they look good at 120DPI.
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I just tested it and it does not. In this case, the scaling happens in the
> skin and not the FXG.
>
> For 240DPI, TabbedViewNavigatorTabBarTabSkinBase.measuredDefaultHeight = 76
> and for 120 DPI, it is set to 38.
Great - just checking.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - Fix for
https://issues.apache.org/jira/browse/FLEX-34139 Adjusted scale values of FXG
elements so that they look good at 120DPI.
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I just tested it and it does not. In this case, the scaling happens in the
skin and not the FXG.
For 240DPI, TabbedViewNavigatorTabBarTabSkinBase.measuredDefaultHeight = 76
and for 120 DPI, it is set to 38.
On Wed, Mar 12, 2014 at 3:37 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> Wouldn't that change make them the same height as the 240 dpi ones? ie
> they will appear twice as big?
>
> Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - Fix for https://issues.apache.org/jira/browse/FLEX-34139 Adjusted scale values of FXG elements so that they look good at 120DPI.
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Wouldn't that change make them the same height as the 240 dpi ones? ie they will appear twice as big?
Justin