You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by carlspring <gi...@git.apache.org> on 2017/07/28 13:13:38 UTC

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

Github user carlspring commented on a diff in the pull request:

    https://github.com/apache/maven-indexer/pull/17#discussion_r130085893
  
    --- Diff: indexer-core/pom.xml ---
    @@ -84,21 +84,25 @@ under the License.
         <dependency>
           <groupId>org.apache.lucene</groupId>
           <artifactId>lucene-core</artifactId>
    +      <version>6.1.0</version>
    --- End diff --
    
    Hi,
    
    Just a small remark, if I may -- this is not the right place to be changing the version. There is a version property defined in the aggregator's `pom.xml`. You should be changing that instead.
    
    Cheers,
    
    Martin



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org