You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:06:06 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2298: Quicksearch API allows to check for cancel.
sdedic opened a new pull request #2298:
URL: https://github.com/apache/netbeans/pull/2298
I've been working with a Quicksearch provider and I noticed that while the Provider can check whether the search query was cancelled when calling `addResult` to the response, there's no way to check if the search was cancelled if the Provider is unable to find any item. In my case, the SearcProvider continues to search even if a new query has been created (provided the Provider still did not found anything).
This simple addition would allow to cancel even such empty-result searches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2298: Quicksearch API allows to check for cancel.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2298:
URL: https://github.com/apache/netbeans/pull/2298#issuecomment-670363274
Yes, the request is, semantically ;) but since there was already an indicator on the `response`, I added the flag method there. I though that an implementation would acquire data from the request (possibly leaving it behind), but I needs to have the response handy in order to accumulate results.
I can move the method, if you people think it is really unnatural :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2298: Quicksearch API allows to check for cancel.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2298:
URL: https://github.com/apache/netbeans/pull/2298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists