You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Yegor Yarko (Jira)" <xe...@xml.apache.org> on 2019/09/10 10:04:00 UTC

[jira] [Commented] (XERCESJ-1668) Off-by-one bug w/ surrogates in UTF8Reader

    [ https://issues.apache.org/jira/browse/XERCESJ-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926486#comment-16926486 ] 

Yegor Yarko commented on XERCESJ-1668:
--------------------------------------

Seems like XERCESJ-1257 describes the same issue, just that what was ArrayOutOfBoundsException is SAXParseException now.

> Off-by-one bug w/ surrogates in UTF8Reader
> ------------------------------------------
>
>                 Key: XERCESJ-1668
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1668
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: Other
>            Reporter: Jan Berkel
>            Priority: Major
>         Attachments: surrogate.patch
>
>
> There's a bug in the surrogate handling when the reader buffer is exhausted and only the high-part can be written. On the next run the low-part gets added but the buffer space calculation is off by one.
> This gets triggered when parsing the current [enwiktionary dump file|http://dumps.wikimedia.org/enwiktionary/20151102/enwiktionary-20151102-pages-articles.xml.bz2].
> {noformat}
> org.xml.sax.SAXParseException; lineNumber: 99849520; columnNumber: 47; Invalid byte 2 of 4-byte UTF-8 sequence.
> {noformat}
> In the attached patch I added a fix + testcase for this bug. Another related issue is that when the low-part is written as last part of the stream -1 is returned instead of 1.
> Is UTF8Reader still necessary? It might be safer to just use a plain InputStreamReader.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org