You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2023/01/10 00:45:03 UTC

[GitHub] [calcite] julianhyde commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

julianhyde commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065235428


##########
babel/src/test/resources/sql/redshift.iq:
##########
@@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01');
 select date_part(minute, date '2009-01-01');
 !ok
 !}
-
+!if (false) {

Review Comment:
   This test should be re-enabled before we accept the PR. If the test is incorrect, fix it. If you need a different DATE_TRUNC function for BQ than for Redshift, that can be accomplished.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org