[GitHub] [incubator-uniffle] advancedxy commented on pull request #730: [#729] improvement: use foreach when iterate Roaring64NavigableMap for better performance

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on PR #730:
URL: https://github.com/apache/incubator-uniffle/pull/730#issuecomment-1473172842

   The code itself looks good to me. 
   
   Do you have any numbers or noticed this inefficiency in profiling .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org