[jira] [Commented] (MRESOLVER-8) Direct dependencies incorrectly detected as transitive.

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662406#comment-15662406 ] 

Hudson commented on MRESOLVER-8:
--------------------------------

SUCCESS: Integrated in Jenkins build maven-resolver #20 (See [https://builds.apache.org/job/maven-resolver/20/])
[MRESOLVER-8] Direct dependencies incorrectly detected as transitive. (schulte: rev 5907bd44682925d8ea795fcb63c39d268157a632)
* (edit) maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_root_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-direct-scope-exclusion-tree.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-transitive-of-direct-scope-exclusion-tree.txt
* (edit) maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectionContext.java
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-pom.txt
* (edit) maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/ScopeDependencySelector.java
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_root_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-root_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-root_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-direct-scope-exclusion-tree.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-direct_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/no-selector-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/optional-exclusion-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_direct-of-root_ver.ini
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-root_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-root-scope-exclusion-tree.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-transitive-of-direct_ver.ini
* (edit) maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_direct-of-root_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-direct-dependency.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-root-exclusion-tree.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/all-nodes.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-transitive-of-direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes-of-pom.txt
* (edit) maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/OptionalDependencySelector.java


> Direct dependencies incorrectly detected as transitive.
> -------------------------------------------------------
>
>                 Key: MRESOLVER-8
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-8
>             Project: Maven Resolver
>          Issue Type: Bug
>            Reporter: Christian Schulte
>            Assignee: Christian Schulte
>            Priority: Critical
>             Fix For: Maven Artifact Resolver 1.2.0
>
>
> The 'DefaultDependencyCollector' updates the state of the 'DependencyCollectionContext' when recursively processing dependencies but does never return the context to the former state. This context is passed to various methods when deriving child components ('DependencyManager.deriveChildManager', 'DependencySelector.deriveChildSelector', 'DependencyTraverser.deriveChildTraverser', 'VersionFilter.deriveChildFilter') which fail to correctly detect the depth/transitivity of the context passed due to that context never getting reset after recursion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)