You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 09:12:41 UTC
[GitHub] [flink] zhuxiaoshang opened a new pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
zhuxiaoshang opened a new pull request #13819:
URL: https://github.com/apache/flink/pull/13819
## What is the purpose of the change
*fix some mistakes in StreamingFileSink*
## Brief change log
- *fix some mistakes in StreamingFileSink*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #13819:
URL: https://github.com/apache/flink/pull/13819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
}, {
"hash" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493)
* 1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-721613927
Thanks for the work @zhuxiaoshang . Merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
}, {
"hash" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8505",
"triggerID" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493",
"triggerID" : "e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693",
"triggerType" : "PUSH"
}, {
"hash" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8505",
"triggerID" : "1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8493)
* 1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #13819:
URL: https://github.com/apache/flink/pull/13819#discussion_r513331116
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -137,12 +137,12 @@ protected StreamingFileSink(
}
/**
- * Creates the builder for a {@link StreamingFileSink} with row-encoding format.
+ * Creates the builder for a {@link StreamingFileSink} with bulk-factory format.
Review comment:
"bulk-factory" -> "bulk-encoding"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13819:
URL: https://github.com/apache/flink/pull/13819#issuecomment-717802407
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 (Wed Oct 28 09:15:53 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org