[jira] [Commented] (FLINK-10358) Flink kinesis connector could throw NPE during getRecords() call

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618348#comment-16618348 ] 

ASF GitHub Bot commented on FLINK-10358:
----------------------------------------

yxu-valleytider opened a new pull request #6708: [FLINK-10358][Kinesis-connector] fix NPE in case millisBehindLatest is null
URL: https://github.com/apache/flink/pull/6708
 
 
   ## What is the purpose of the change
   
   This PR fixes the NPE described in [Flink-10358](https://issues.apache.org/jira/browse/FLINK-10358). The issue happens when extending the flink Kinesis connector to consume from dynamodb streams (see also [Flink-4582](https://issues.apache.org/jira/browse/FLINK-4582)).
   
   ## Brief change log
   
   Check to avoid NPE been thrown inside `ShardConsumer.java`.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink kinesis connector could throw NPE during getRecords() call 
> -----------------------------------------------------------------
>
>                 Key: FLINK-10358
>                 URL: https://issues.apache.org/jira/browse/FLINK-10358
>             Project: Flink
>          Issue Type: Bug
>          Components: Kinesis Connector
>            Reporter: Ying Xu
>            Assignee: Ying Xu
>            Priority: Major
>              Labels: pull-request-available
>
> When extending the flink kinesis connector to consume from a dynamodb stream, it was found NPE could be thrown at [here|https://github.com/apache/flink/blob/e3c98f05d3544d0165c2d97d2d00fcd295cef8c8/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L376] . 
> This is because the [getRecords API|https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_streams_GetRecords.html] in dynamodb streams does not return the millisBehindLatest field and has it set to null.  Null check is probably needed here.
> See FLINK-4582 for the context of building dynamodb streams connector on top of the Kinesis connector. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)