[jira] [Commented] (FLINK-14332) add flink-metrics-signalfx to flink-metrics

["Luke Sun (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024922#comment-17024922 ] 

Luke Sun commented on FLINK-14332:
----------------------------------

# current metric full name is from MetricGroup getScopeComponents(), and remove MetricGroup getAllVariables(), and finally append metricName from notifier. The getAllVariables() store as SFX dimensions that are similar to Graphite 1.1.x tags.
 # SFX AggregateMetricSender works as reporter to send protobuf data point to SFX backend
 # support Gauge, Meter and Counter
 # remove unnecessary tests
 # remove codahale dependency

 

Could someone review this PR when available?

> add flink-metrics-signalfx to flink-metrics
> -------------------------------------------
>
>                 Key: FLINK-14332
>                 URL: https://issues.apache.org/jira/browse/FLINK-14332
>             Project: Flink
>          Issue Type: New Feature
>          Components: Runtime / Metrics
>            Reporter: Luke Sun
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> To support the [SignalFX|[https://www.signalfx.com/]] API and library dependencies:
>  * com.signalfx.public:signalfx-java
>  * com.signalfx.public:signalfx-codahale
> and add shaded package because io.dropwizard.metrics:metrics-core dependency is not equal to flink-metrics-dropwizard.
>  
> flink-conf.yaml
> {code:java}
>     metrics.reporter.signalfx.class: org.apache.flink.metrics.signalfx.ScheduledSignalFXReporter
>     metrics.reporter.signalfx.interval: 60 SECONDS
>     metrics.reporter.signalfx.token: xxx
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)