You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Eugene Koifman (JIRA)" <ji...@apache.org> on 2019/01/09 01:40:00 UTC
[jira] [Updated] (HIVE-21106) Potential NEP in
VectorizedOrcAcidRowBatchReader.ColumnizedDeleteEventRegistry
[ https://issues.apache.org/jira/browse/HIVE-21106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koifman updated HIVE-21106:
----------------------------------
Description:
{{VectorizedOrcAcidRowBatchReader.ColumnizedDeleteEventRegistry()}}
{noformat}
AcidStats acidStats = OrcAcidUtils.parseAcidStats(deleteDeltaReader);
if (acidStats.deletes == 0) {
continue; // just a safe check to ensure that we are not reading empty delete files.
}
{noformat}
If the {{delete_delta../bucket_x}} is empty, it may not have a {{hive.acid.index}} and {{OrcAcidUtils.parseAcidStats()}} will return null which causes NPE.
Even though HIVE-20941 will ensure empty files are no longer created but empty files predating that fix may exist
was:
{{VectorizedOrcAcidRowBatchReader.ColumnizedDeleteEventRegistry()}}
{noformat}
AcidStats acidStats = OrcAcidUtils.parseAcidStats(deleteDeltaReader);
if (acidStats.deletes == 0) {
continue; // just a safe check to ensure that we are not reading empty delete files.
}
{noformat}
If the {{delete_delta../bucket_x}} is empty, it may not have a {{hive.acid.index}} and {{OrcAcidUtils.parseAcidStats()}} will return null which causes NPE.
> Potential NEP in VectorizedOrcAcidRowBatchReader.ColumnizedDeleteEventRegistry
> ------------------------------------------------------------------------------
>
> Key: HIVE-21106
> URL: https://issues.apache.org/jira/browse/HIVE-21106
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Priority: Major
>
> {{VectorizedOrcAcidRowBatchReader.ColumnizedDeleteEventRegistry()}}
> {noformat}
> AcidStats acidStats = OrcAcidUtils.parseAcidStats(deleteDeltaReader);
> if (acidStats.deletes == 0) {
> continue; // just a safe check to ensure that we are not reading empty delete files.
> }
> {noformat}
> If the {{delete_delta../bucket_x}} is empty, it may not have a {{hive.acid.index}} and {{OrcAcidUtils.parseAcidStats()}} will return null which causes NPE.
> Even though HIVE-20941 will ensure empty files are no longer created but empty files predating that fix may exist
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)